Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new condition to check the distance between an object and a position #6738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tristanbob
Copy link
Contributor

Fixes #3815.

Game Example:

Add Distance Conditions.zip

Video

electron_p9lsOTt2uj.mp4

@tristanbob tristanbob requested a review from 4ian as a code owner July 2, 2024 04:21
@4ian
Copy link
Owner

4ian commented Jul 2, 2024

This increases the "surface of the API" of base objects. In other words: yet another condition in an already very (too?) big list of conditions. I think we need at some point to reorganize it or introduce some more grouping. cc @ClementPasteau @D8H

@D8H
Copy link
Collaborator

D8H commented Jul 2, 2024

I don't know how it can be reorganized. I'm not found of groups with 2 instructions.

I guess the same thing could apply to this condition:
image

GDJS/Runtime/runtimeobject.ts Outdated Show resolved Hide resolved
GDJS/Runtime/events-tools/objecttools.ts Outdated Show resolved Hide resolved
@tristanbob
Copy link
Contributor Author

I've updated this PR with the suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Distance between positions" and "Distance between object and position" condition
3 participants