Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port MHD from Nyx #162

Closed
zingale opened this issue Aug 21, 2017 · 4 comments
Closed

port MHD from Nyx #162

zingale opened this issue Aug 21, 2017 · 4 comments
Assignees
Labels

Comments

@zingale
Copy link
Member

zingale commented Aug 21, 2017

the MHD port should be straightforward. Some thoughts:

  • we don't need any cosmological expansion factors
  • we need to ensure that it works with a general EOS
  • can we hook in radiation too? it may be straightforward with MOL and reusing the implicit solve
  • can we still do the same conservative gravity?
@zingale
Copy link
Member Author

zingale commented Nov 13, 2017

Here's some status:

  • There are a number of places where gamma_const and gamma_minus_one appear -- I've marked these with comments beginning with ! TODO along with my thoughts on how to fix (usually calling an EOS)

  • For the transverse update and Riemann, this does not do the method we use in hydro of separately evolving (rho e) and p. For now, we'll just use the EOS to make everything we need

  • species seem to be incomplete. In particular, there are a number of places in the convert from primitive and conserved (and back) that don't seem to manage the density factors.

@zingale
Copy link
Member Author

zingale commented Nov 13, 2017

In Castro_mhd.cpp, the following todos remain:

  • the source terms are not implemented
  • the flux registers are not filled

@zingale
Copy link
Member Author

zingale commented Dec 7, 2017

There are a lot of places where we go between E and e in the code. We now need to make sure that all of these places include the magnetic energy as well, as:

rho E = rho e + K + 0.5 * B**2

Here's a list of places to change:

  • enforce_consistent_e

@zingale zingale added the mhd label Dec 13, 2017
@zingale zingale closed this as completed May 13, 2020
@zingale
Copy link
Member Author

zingale commented May 13, 2020

MHD was merged in PR #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants