MHD #307
MHD #307
Conversation
some changes in eos_soundspeed_mhd
…ude there the magnetic e term if using MHD
moved the initializing magnetic fields part, so when enforce_consistent_e is called, that information is passed
getting hydro_source instead of modifying S_new next chage will include the use of thermo_source
now using thermo_source for the contribution of -pdivu on UEINT removed the contribution of SrCQ from plm for now, will add those contributions soon
this compiles and the input files run
|
For the tests in the MHD directory, can you please remove the tests that are duplicates of existing problem setups like DustCollapse and wdmerger? I'm OK with you adding new inputs files to existing setups, and adding the initmag calls where necessary. That is preferable to maintaining two versions of each setup. |
Source/driver/Derive_F.H
Outdated
| #endif | ||
|
|
||
| #ifdef MHD | ||
| void ca_dermagcenx |
There was a problem hiding this comment.
These will need to be converted to the new Derive interface.
and added necessary inputs and changes to the one in gravity_tests
Source/driver/meth_params.template
Outdated
| @@ -17,6 +17,10 @@ module meth_params_module | |||
|
|
|||
| ! number of ghost cells for the hyperbolic solver | |||
| integer, parameter :: NHYP = 4 | |||
| #ifdef MHD | |||
| integer, parameter :: MAXADV = 5 | |||
There was a problem hiding this comment.
I don't think MAXADV is used anywhere
There was a problem hiding this comment.
agree, we don't need it. At least grep suggests that :)
Source/hydro/Castro_hydro.cpp
Outdated
| MultiFab& By = get_new_data(Mag_Type_y); | ||
| MultiFab& Bz = get_new_data(Mag_Type_z); | ||
| #endif | ||
|
|
There was a problem hiding this comment.
are these needed in Castro_hydro.cpp?
There was a problem hiding this comment.
nope, doesn't seem like we need them there
|
I'd prefer if we avoided checking in unclean notebooks into the main repo. |
added the inputs and probin in the science/wdmerger/tests/wdmerger_mhd
now this test is in hydro_test
I think it is done |
So far it looks like the MHD solver works in the absence of B fields