Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the BC logic in Detonation was checking on REFLECT_ODD twice #2722

Merged
merged 1 commit into from
Jan 22, 2024
Merged

the BC logic in Detonation was checking on REFLECT_ODD twice #2722

merged 1 commit into from
Jan 22, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jan 21, 2024

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale mentioned this pull request Jan 21, 2024
Merged
5 tasks
@zingale zingale merged commit 29c5f4d into AMReX-Astro:development Jan 22, 2024
20 checks passed
@zingale zingale deleted the fix_some_det_bc_logic branch January 22, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23