Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of asctime -- it is unsafe #2793

Merged
merged 2 commits into from
Mar 19, 2024
Merged

get rid of asctime -- it is unsafe #2793

merged 2 commits into from
Mar 19, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 19, 2024

flagged by clang-tidy bugprone-unsafe-functions

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@yut23
Copy link
Collaborator

yut23 commented Mar 19, 2024

It looks like we can get rid of the buffer if we use std::put_time(): https://en.cppreference.com/w/cpp/io/manip/put_time#Example

@zingale
Copy link
Member Author

zingale commented Mar 19, 2024

updated

@zingale zingale merged commit 3942b71 into AMReX-Astro:development Mar 19, 2024
23 checks passed
@zingale zingale deleted the replace_asctime branch March 19, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23