Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retry timelevels when amr.subcycle_mode = None #2821

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 10, 2024

when we are not doing AMR subcycling and trigger a retry, we will advance all levels again at the new timestep. However, we were not properly resetting the timelevels in the StateData to reflect the new subcycled timestep.

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

when we are not doing AMR subcycling and trigger a retry, we
will advance all levels again at the new timestep.  However,
we were not properly resetting the timelevels in the StateData
to reflect the new subcycled timestep.
@zingale
Copy link
Member Author

zingale commented Apr 10, 2024

This fixes #2820, but we need to make sure that there are not any other issues when doing retry w/o subcycling.

@zingale zingale merged commit 3d76cd5 into AMReX-Astro:development Apr 11, 2024
25 checks passed
@zingale zingale deleted the nosubcycling branch April 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants