Create problem to study He flame movement in a double det #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zingale
reviewed
Jun 11, 2024
|
|
||
| // Set up Castro data logs for this problem | ||
|
|
||
| if (castro::sum_interval > 0 && amrex::ParallelDescriptor::IOProcessor()) { |
There was a problem hiding this comment.
this entire if-block can be removed
zingale
reviewed
Jun 11, 2024
| state(i,j,k,UMY) = 0.0_rt; | ||
| state(i,j,k,UMZ) = 0.0_rt; | ||
|
|
||
| // Now add the velocity perturbation |
There was a problem hiding this comment.
this entire if-block can be removed -- we will not do a velocity perturbation
zingale
reviewed
Jun 11, 2024
Exec/science/subch_planar/inputs_2d
Outdated
| # PROBLEM PARAMETERS | ||
| problem.model_name = "toy_subch.hse.tanh.delta_50.00km.dx_73.24km" | ||
|
|
||
| problem.apply_vel_field = 1 |
There was a problem hiding this comment.
all of these problem.* parameters are not needed here
zingale
reviewed
Jun 11, 2024
| @@ -0,0 +1,19 @@ | |||
| H_min real 1.e-4_rt y | |||
|
|
|||
| cutoff_density real 50.0_rt y | |||
zingale
reviewed
Jun 11, 2024
|
|
||
| model_name string "" y | ||
|
|
||
| apply_vel_field integer 0 y |
There was a problem hiding this comment.
this parameter and all following are not needed
zingale
reviewed
Jun 15, 2024
Exec/science/subch_planar/inputs_2d
Outdated
| amr.derive_plot_vars = ALL | ||
|
|
||
| # PROBLEM PARAMETERS | ||
| problem.model_name = "toy_subch.hse.tanh.delta_50.00km.dx_73.24km" |
There was a problem hiding this comment.
this is the wrong initial model file
zingale
reviewed
Jun 15, 2024
zingale
reviewed
Jun 15, 2024
| # This sets the EOS directory in $(MICROPHYSICS_HOME)/eos | ||
| EOS_DIR := helmholtz | ||
|
|
||
| # This sets the EOS directory in $(MICROPHYSICS_HOME)/networks |
zingale
reviewed
Jun 16, 2024
Exec/science/subch_planar/Problem.H
Outdated
| @@ -0,0 +1 @@ | |||
| amrex::Real maxVal (const std::string& name, amrex::Real time); | |||
zingale
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Begin creating a problem to study the lateral movement of a He flame in the accreted layer of a white dwarf.
PR motivation
We want to determine how various shock detection thresholds and burning treatments affect the initial flame movement in a double detonation model. In particular, we seek to see if the results of disabling/enabling burning in detected shock zones converges as resolution becomes finer.
PR checklist
CHANGESfile has been updated, if appropriate