Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compute_new_dt_on_regrid by default #720

Merged
merged 2 commits into from
Dec 29, 2019

Conversation

maxpkatz
Copy link
Member

PR summary

The AMR parameter amr.compute_new_dt_on_regrid is now on by default; closes #356. This avoids crashes that result from the CFL number being too large after regridding, because we update the timestep after seeing that larger velocity.

The user can still opt to set this off if they want to, since the location where we're setting it in Castro occurs before the Amr ParmParse of this parameter.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite
  • all functions have docstrings as per the coding conventions
  • the CHANGES file has been updated
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member

zingale commented Dec 29, 2019

@zingale zingale merged commit 45282cf into development Dec 29, 2019
@zingale zingale deleted the compute_new_dt_on_regrid branch December 29, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants