Remove integrate_Planck option, always integrate by default #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There existed an option to turn off the normal behavior of integrating the Planck function to get the blackbody spectrum at each group center. This was only used in the RadSphere test, and the alternative was to evalute the Planck function as piecewise constant within each energy group. This introduces code complexity without any obvious gain; we still get reasonable results using the more general expression, and reduce the number of code paths to maintain.
zingale
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
There existed an option to turn off the normal behavior of integrating the Planck function to get the blackbody spectrum at each group center. This was only used in the RadSphere test, and the alternative was to evalute the Planck function as piecewise constant within each energy group. This introduces code complexity without any obvious gain; we still get reasonable results using the more general expression, and reduce the number of code paths to maintain.
PR checklist
CHANGESfile has been updated