Handle the plotfile case where a derived variable has multiple components #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents In this case, the plotfile logic would only plot the first component of the derived variable. Now, if a derived variable has multiple components, we plot all components. The name of each is appended with an integer variable indicating which one it is.
|
The most common case affected by this will be the StateErr derived variable, which is part of the default set of Castro derives. Now each plotfile will have "StateErr_0", "StateErr_1", and "StateErr_2", so the regression suite will need to be updated. |
|
the test suite never completes with this PR. The Detonation test has been running for ~12 hours. Going to kill it now. |
Conflicts: Source/driver/Castro_io.cpp
|
Fixed a bug, I was accidentally trying to plot too many variables. |
zingale
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In this case, the plotfile logic would only plot the first component of the derived
variable. Now, if a derived variable has multiple components, we plot all components.
The name of each is appended with an integer variable indicating which one it is.
This issue also exists in AMReX, where this plotfile code presumably originally came from.
PR checklist
CHANGESfile has been updated