remove the reconstruction of gamma_e on interfaces #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is temporary
|
Note: as a consequence of this, we will be removing the ppm_temp_fix = 1 option from CTU (since apparently it was never coded into the default rhoe reconstruction for some reason). See issue #781 |
|
This depends on #768 |
|
all tests, aside from the 2 that explicitly used gammae tracing, pass. |
maxpkatz
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This drops the alternative to (rho e) on interfaces -- reconstructing gamma_e. They both are about the same, so there's no need to support both
PR checklist
CHANGESfile has been updated