Switch over generic_fill/hypfill to AMReX implementation #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zingale
approved these changes
Apr 11, 2020
5 tasks
zingale
pushed a commit
that referenced
this pull request
Jun 21, 2020
PR #837 removed the need for any problem setup to call amrex_filccn in its local bc_fill_nd.F90 routines, hypfill and denfill, because now we will always call the AMReX BC routines prior to entering hypfill or denfill. However that PR did not remove the calls to it from the problem setups that used it, noting that these calls are now redundant. These calls are now removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
AMReX provides
CpuBndryFuncFabandGpuBndryFuncFabwhich are very similar to whatgeneric_fillandhypfilldid. The AMReX implementations are now used. We still have ahypfillanddenfillfunction, so that existing problems are not broken, but the main one inSource/no longer callsamrex_filcc(it only has the ambient code now). The problems that do override bc_fill_nd.F90 are thus no longer required to call amrex_filcc, although I have left them alone for now (they will just redundantly do it a second time).PR checklist
CHANGESfile has been updated