Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port some routines to C++ #853

Merged
merged 11 commits into from
Apr 17, 2020
Merged

port some routines to C++ #853

merged 11 commits into from
Apr 17, 2020

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 13, 2020

PR summary

This ports the hydro and diffusion timestep limiters and the thermo source to C++

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite
  • all functions have docstrings as per the coding conventions
  • the CHANGES file has been updated
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Apr 13, 2020

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2020-04-13-002/index.html

stuff with a general EOS can be a little different due to the slight diffs between the Fortran and C++ EOS.

@maxpkatz
Copy link
Member

Looks good for CPU. You'll need to make sure lambda capture is working correctly for the CUDA build.

@zingale
Copy link
Member Author

zingale commented Apr 17, 2020

@zingale zingale merged commit 3cb89ea into development Apr 17, 2020
@zingale zingale deleted the cxx_porting branch April 17, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants