-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the Reactions_Type StateData #927
Conversation
Its first NumSpec components are rho * omegadot rather than omegadot; then, the NumAux auxiliary components are stored, if the network has any auxiliary variables; then, rho * enuc is stored (enuc itself is removed), and finally the burn weights are stored. The checkpoint version has been incremented.
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2020-05-21-002/index.html |
OK. Can you look at the SDC change at the bottom and tell me what I did wrong? I didn't really get what's going in store_reaction_state. |
I've updated the simplified SDC burn to be consistent with this PR. Also I fixed the crashes in flame and toy_flame. Ready for retest. |
Latest tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2020-05-23/index.html I am satisfied with these. The derived fields We'll need a full test suite reset after this since most tests now have a different set of variables in their plotfile. |
PR summary
The first NumSpec components of Reactions_Type are rho * omegadot rather than omegadot; then, the NumAux auxiliary components are stored, if the network has any auxiliary variables; then, rho * enuc is stored (enuc itself is removed), and finally the burn weights are stored. The checkpoint version has been incremented.
Some
reactions_max_solve_level
code which was accidentally removed in #922 is restored.The derives in the flame and toy_flame problems are updated -- it looks like they were not correct before, because we intended to integrate (rho omegadot) before but were only integrating omegadot.
PR motivation
This cleanup, where the calculation of the burn is separate from the application to the state, will help make it easier to do certain experimentation we'd like to do with the burning, such as doing a higher-order burn, and doing the burn in parallel on the CPU and GPU.
PR checklist
CHANGES
file has been updated, if appropriate