Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Reactions_Type StateData #927

Merged
merged 10 commits into from
Jun 8, 2020

Conversation

maxpkatz
Copy link
Member

@maxpkatz maxpkatz commented May 7, 2020

PR summary

The first NumSpec components of Reactions_Type are rho * omegadot rather than omegadot; then, the NumAux auxiliary components are stored, if the network has any auxiliary variables; then, rho * enuc is stored (enuc itself is removed), and finally the burn weights are stored. The checkpoint version has been incremented.

Some reactions_max_solve_level code which was accidentally removed in #922 is restored.

The derives in the flame and toy_flame problems are updated -- it looks like they were not correct before, because we intended to integrate (rho omegadot) before but were only integrating omegadot.

PR motivation

This cleanup, where the calculation of the burn is separate from the application to the state, will help make it easier to do certain experimentation we'd like to do with the burning, such as doing a higher-order burn, and doing the burn in parallel on the CPU and GPU.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

Its first NumSpec components are rho * omegadot rather than omegadot; then,
the NumAux auxiliary components are stored, if the network has any auxiliary
variables; then, rho * enuc is stored (enuc itself is removed), and finally
the burn weights are stored. The checkpoint version has been incremented.
@maxpkatz maxpkatz marked this pull request as ready for review May 14, 2020 12:27
@zingale
Copy link
Member

zingale commented May 21, 2020

@maxpkatz
Copy link
Member Author

maxpkatz commented May 23, 2020

there are some crashes here

OK. Can you look at the SDC change at the bottom and tell me what I did wrong? I didn't really get what's going in store_reaction_state.

@maxpkatz
Copy link
Member Author

I've updated the simplified SDC burn to be consistent with this PR. Also I fixed the crashes in flame and toy_flame. Ready for retest.

@maxpkatz
Copy link
Member Author

Latest tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2020-05-23/index.html

I am satisfied with these. The derived fields enuc and t_sound_t_enuc have relatively large diffs in some cases but it was not expected that these should have stayed exactly the same since we are now deriving this based on the change to UEINT.

We'll need a full test suite reset after this since most tests now have a different set of variables in their plotfile.

@zingale zingale merged commit 313543e into AMReX-Astro:development Jun 8, 2020
@maxpkatz maxpkatz deleted the reactions_type branch July 7, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants