Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dtnuc_T burning timestep limiter #972

Merged
merged 2 commits into from
May 18, 2020

Conversation

maxpkatz
Copy link
Member

PR summary

Similar to dtnuc_e and dtnuc_X, a timestep limiter dtnuc_T is added which restricts the burning from updating the temperature by more than the factor dtnuc_T * T / dT/dt.

PR motivation

For a real WD equation of state the temperature is extremely sensitive to e, so limiting the timestep based on only de/dt may allow large temperature swings. Since the reaction rates are so sensitive to T, this could mean we cannot stop large changes in T without an explicit limiter on T.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review May 18, 2020 19:27
@zingale zingale merged commit c417aaa into AMReX-Astro:development May 18, 2020
@maxpkatz maxpkatz deleted the dtnuc_T branch May 18, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants