Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixind defaults.yml #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixind defaults.yml #81

wants to merge 1 commit into from

Conversation

insspb
Copy link
Contributor

@insspb insspb commented Feb 17, 2016

This fix will:
Moving from static worker process to ansible selected. Values is based on nginx recommendations.
Defaults file quotes fix.

I have travis error on source download while testing. This is not related to particular change.

@soupdiver
Copy link
Contributor

Hmmm this adds complexity to the configuration because of all these implicit values. Probably it's a good idea to have as many workers as cores but it's implicit and on different systems this causes different configurations even if you don't change anything.

As always this has pros and cons.

What's your opinion about flexibility vs. easyness @otakup0pe @pjan @farridav ?

@insspb
Copy link
Contributor Author

insspb commented Feb 17, 2016

You can always change this value in defaults or in host settings,
but let's be real how many virtual pc's are with 4 cores (current config) inside on deploy?
And as the other side, when you scale up virtual pc or server with my config you do not need to think about reconfiguration. It will be done by ansible on run.

@soupdiver
Copy link
Contributor

I know you can change the values all the time. It's more about simplicity and predictable behaviour.
Would like to get some feedback of the others before deciding on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants