Removed unused variables, as they add to confusion #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gclough
commented
Apr 15, 2019
defaults/main.yml
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| # Basic settings | |||
| postgresql_version: 11 | |||
| # Short version of the postgresql_version, used in some path and filenames | |||
There was a problem hiding this comment.
Moved postgresql_version_terse next to the postgresql_version, rather than in a random place down the file.
gclough
commented
Apr 15, 2019
| @@ -15,6 +17,10 @@ postgresql_ctype_parts: | |||
| - "UTF-8" # Encoding | |||
| postgresql_ctype: "{{ postgresql_ctype_parts | join('.') }}" | |||
|
|
|||
| postgresql_env: | |||
There was a problem hiding this comment.
Moved postgresql_env close to the other environment variables, rather than in some random place further down in the file.
gclough
commented
Apr 15, 2019
| @@ -117,10 +123,6 @@ postgresql_unix_socket_directories: # (>= 9.3) | |||
| postgresql_unix_socket_group: "" | |||
| postgresql_unix_socket_permissions: "0777" # begin with 0 to use octal notation | |||
|
|
|||
| # Automatic pg_ctl configuration. Specify a list of options containing | |||
There was a problem hiding this comment.
Completely unused, so removed.
gclough
commented
Apr 15, 2019
| @@ -759,10 +761,9 @@ postgresql_pgtune_type: "Mixed" | |||
| # Maximum number of expected connections, if "no", default based on db type | |||
| postgresql_pgtune_connections: no | |||
|
|
|||
|
|
|||
| postgresql_env: | |||
There was a problem hiding this comment.
Moved up to a better spot.
gclough
commented
Apr 15, 2019
| postgresql_env: | ||
| LC_ALL: "{{ postgresql_locale }}" | ||
| LC_LCTYPE: "{{ postgresql_locale }}" | ||
| #------------------------------------------------------------------------------ |
gclough
commented
Apr 15, 2019
| @@ -774,67 +775,6 @@ postgresql_apt_repository: "deb http://apt.postgresql.org/pub/repos/apt/ {{ ansi | |||
| # Pin-Priority of PGDG repository | |||
| postgresql_apt_pin_priority: 500 | |||
|
|
|||
| # Yum settings | |||
There was a problem hiding this comment.
Completely unused... so we've been maintaining this for nothing.
gclough
commented
Apr 15, 2019
| 11: 2, | ||
| } | ||
|
|
||
| postgresql_version_terse: "{{ postgresql_version | replace('.', '') }}" |
There was a problem hiding this comment.
Moved up to a more logical location
gclough
force-pushed
the
cleanup_old_yum_variables
branch
from
67051d5
to
a4da676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused default variables (as in not used ANYWHERE). Checked with:
I've also moved some of them to a more logical location.