escape dollar signs in component.js #params #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
evandavis
reviewed
Jan 13, 2017
| text = text.replace(reg, _params[k]); | ||
| // Escape possible '$' in params to prevent unexpected behavior with .replace() | ||
| // especially important for IE11, which misinterprets '$0' as a regex command | ||
| var param = _params[k].replace(/\$/g, '$$$$'); |
There was a problem hiding this comment.
This assumes that the param value is going to be a string when before you could pass a number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape dollar signs passed to t() function.
This fixes unexpected output for strings that contain dollar signs passed to t() via the params object. These can be interpreted by Javascript's String.prototype.replace() as replacement patterns.
Addresses issue #13