New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert numbers to strings in params before replace #15

Merged

francescarpi merged 1 commit into APSL:master from relayrides:b/numbers-in-t-params

Jan 13, 2017

Contributor

gannoncurran commented Jan 13, 2017

Discovered a bug in my changes — when numbers are passed in as params, they caused
.replace(/\$/g, '$$$$') in params function to fail.

Now converting to strings to fix.


          fix: convert numbers to strings in params before replace

545dc21

francescarpi merged commit 99507f4 into APSL:master

Member

francescarpi commented Jan 13, 2017

Thanks again! I going to publish it now.

evandavis mentioned this pull request

[Fix] don't assume everything is a string #16

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet