Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Fix path to STM32F0 GCC linker scripts #14318

Merged
merged 1 commit into from
Feb 23, 2021
Merged

CMake: Fix path to STM32F0 GCC linker scripts #14318

merged 1 commit into from
Feb 23, 2021

Conversation

harmut01
Copy link
Contributor

@harmut01 harmut01 commented Feb 22, 2021 •
edited by hugueskamba
Loading

Summary of changes

The linux filesystem is case sensitive, this was causing our nightly build to
fail when attempting to find the linker script using its lower case name. The
name of the file has been kept the same as this seems to be STMs convention.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@harrisonmutai-arm
Fix path to GCC linker scripts
5899dd0 
The linux filesystem is case sensitive, this was causing our nightly build to
fail when attempting to find the script with its lower case name. The
name of the file has been kept the same as this seems to be STMs
convention.
@mergify mergify bot added the needs: CI label Feb 22, 2021
0xc0170
0xc0170 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Feb 23, 2021
@0xc0170 0xc0170 merged commit da51cb2 into ARMmbed:master Feb 23, 2021
@mergify mergify bot removed the ready for merge label Feb 23, 2021
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

@saheerb saheerb Awaiting requested review from saheerb

Assignees
No one assigned
Labels
release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@harmut01 @mbed-ci @Patater @0xc0170 @jeromecoutant @hugueskamba @mbedmain @harrisonmutai-arm