Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM_MPS2_Target: Fix conflicts in IAR configuration #14350

Merged
merged 1 commit into from
Feb 25, 2021
Merged

ARM_MPS2_Target: Fix conflicts in IAR configuration #14350

merged 1 commit into from
Feb 25, 2021

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Feb 25, 2021 •
edited
Loading

Summary of changes

In targets.json, the base target ARM_MPS2_Target does not have iar
in supported_c_libs. But its inherited targets have IAR in
supported_toolchains, causing configuration check to fail.

Impact of changes

None.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @ARMmbed/mbed-os-maintainers

@LDong-Arm
Fix conflicts in IAR configuration
c1d115e 
In `targets.json`, the base target ARM_MPS2_Target does not have `iar`
in `supported_c_libs`. But its inherited targets have `IAR` in
`supported_toolchains`, causing configuration check to fail.
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2021

CI started

@LDong-Arm LDong-Arm mentioned this pull request Feb 25, 2021
Merged
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 25, 2021
@ciarmcom
Copy link
Member

@LDong-Arm, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from 0xc0170 and a team February 25, 2021 12:30
@LDong-Arm LDong-Arm changed the title Fix conflicts in IAR configuration ARM_MPS2_Target: Fix conflicts in IAR configuration Feb 25, 2021
@mbed-ci
Copy link

mbed-ci commented Feb 25, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 36b6013 into ARMmbed:master Feb 25, 2021
@mergify mergify bot removed the ready for merge label Feb 25, 2021
@LDong-Arm LDong-Arm mentioned this pull request Feb 25, 2021
Merged
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LDong-Arm @0xc0170 @ciarmcom @mbed-ci @Patater @mbedmain