Make TimeProvider nullable in config

Abc-Arbitrage · Jul 22, 2024 · 552ad83 · 552ad83
1 parent b035cde
commit 552ad83
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/ZeroLog.Impl.Full/Configuration/ResolvedLoggerConfiguration.cs b/src/ZeroLog.Impl.Full/Configuration/ResolvedLoggerConfiguration.cs
@@ -67,7 +67,6 @@ public static ResolvedLoggerConfiguration Resolve(string loggerName, ZeroLogConf
         {
             LogMessagePoolExhaustionStrategy = effectiveLogMessagePoolExhaustionStrategy,
 #if NET8_0_OR_GREATER
-            // ReSharper disable once NullCoalescingConditionIsAlwaysNotNullAccordingToAPIContract
             TimeProvider = configuration.TimeProvider ?? TimeProvider.System
 #endif
         };

diff --git a/src/ZeroLog.Impl.Full/Configuration/ZeroLogConfiguration.cs b/src/ZeroLog.Impl.Full/Configuration/ZeroLogConfiguration.cs
@@ -126,9 +126,9 @@ public bool UseBackgroundThread
     /// The time provider to use for message timestamps.
     /// </summary>
     /// <remarks>
-    /// Default: <see cref="System.TimeProvider.System"/>.
+    /// Default: <c>null</c>, which falls back to <see cref="System.TimeProvider.System"/>.
     /// </remarks>
-    public TimeProvider TimeProvider { get; init; } = TimeProvider.System;
+    public TimeProvider? TimeProvider { get; init; }
 #endif
 
     /// <summary>

diff --git a/src/ZeroLog.Tests/SanityChecks.should_have_expected_public_api.DotNet8_0.verified.txt b/src/ZeroLog.Tests/SanityChecks.should_have_expected_public_api.DotNet8_0.verified.txt
@@ -111,7 +111,7 @@ namespace ZeroLog.Configuration
         public int LogMessageBufferSize { get; init; }
         public int LogMessagePoolSize { get; init; }
         public int LogMessageStringCapacity { get; init; }
-        public System.TimeProvider TimeProvider { get; init; }
+        public System.TimeProvider? TimeProvider { get; init; }
         public bool UseBackgroundThread { get; init; }
         public void ApplyChanges() { }
         public void SetLogLevel(string? loggerName, ZeroLog.LogLevel? logLevel) { }