Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove python-2 pyyaml lib #1845

Conversation

maxnbk
Copy link
Contributor

@maxnbk maxnbk commented Oct 11, 2024

Just reducing the rez repo & package footprint by a bit, considering we have dropped py2.
(probably should update pyyaml to 6 too, but separate PR)

Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
@maxnbk maxnbk requested a review from a team as a code owner October 11, 2024 20:53
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.58%. Comparing base (8476696) to head (239a09c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1845      +/-   ##
==========================================
+ Coverage   58.52%   58.58%   +0.05%     
==========================================
  Files         126      126              
  Lines       17207    17207              
  Branches     3519     3017     -502     
==========================================
+ Hits        10070    10080      +10     
- Misses       6468     6474       +6     
+ Partials      669      653      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot to do that. Thanks!

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit b9ab034 into AcademySoftwareFoundation:main Oct 13, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants