Add a parameter for blur amount in the Fire 2012 effect #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase for 0_15 branch. |
apanteleev
force-pushed
the
fire-blur-control
branch
from
5134ef9
to
0af1ec3
Compare
|
Rebased. |
|
I will merge this but just out of curiosity, did you check speed with 0_15 branch? There were some optimisations done regarding blur. |
Not when submitting the PR, but now I did. 29 FPS with blur, 43 FPS without. So, much faster than 0.14 - thanks for letting me know! |
softhack007
pushed a commit
to MoonModules/WLED
that referenced
this pull request
Aug 8, 2024
Add a parameter for blur amount in the Fire 2012 effect
softhack007
pushed a commit
to MoonModules/WLED
that referenced
this pull request
Aug 9, 2024
Add a parameter for blur amount in the Fire 2012 effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a larger 2D matrix, blur becomes very expensive in terms of performance. On ESP32 with a 32x24 matrix, the Fire 2012 effect with blur runs at 13 FPS, and without blur at about 30 FPS. Sometimes more, but I couldn't figure out why.
This PR adds a user setting for the blur amount so that you can set it to 0 or any other value for aesthetic reasons.