Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow set custom app name via env #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow set custom app name via env #293

wants to merge 1 commit into from

Conversation

ErnyTech
Copy link

@ErnyTech ErnyTech commented Oct 12, 2023 •
edited
Loading

This is especially useful because of this electron/electron#33155

@Ajaxy
Copy link
Owner

Ajaxy commented Oct 13, 2023

Can you elaborate, what is the purpose? Also, please make sure to comply with the linter rules.

@ErnyTech
Copy link
Author

Electron sets WM_CLASS based on app name, currently equivalent to "Telegram A".
Unfortunately on Linux to get the application icon on the task manager it is necessary that the WM_CLASS must correspond to the name of the icon, to be able to optimally package the application on a Linux distro it is necessary to have a WM_CLASS without spaces.
This patch is useful for doing this without changing the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErnyTech @Ajaxy