fix(UI): selectAll button was still keeping alle items in memory

Alinto · Nov 22, 2023 · 1ae02eb · 1ae02eb
1 parent aa53524
commit 1ae02eb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/UI/WebServerResources/js/Mailer/MailboxController.js b/UI/WebServerResources/js/Mailer/MailboxController.js
@@ -581,9 +581,10 @@
         folder.$selectedMessages = [];
         for (; i < length; i++) {
           folder.$messages[i].selected = !vm.allSelected;
-          folder.$selectedMessages.push(folder.$messages[i]);
+          if(folder.$messages[i].selected)
+            folder.$selectedMessages.push(folder.$messages[i]);
+            count++;
         }
-        count += length;
       });
       vm.allSelected = !vm.allSelected;
       vm.mode.multiple = count;

diff --git a/UI/WebServerResources/js/Scheduler/CalendarListController.js b/UI/WebServerResources/js/Scheduler/CalendarListController.js
@@ -140,19 +140,20 @@
     }
 
     function confirmDeleteSelectedComponents() {
-      Dialog.confirm(l('Warning'),
-                     l('Are you sure you want to delete the selected components?'),
-                     { ok: l('Delete') })
-        .then(function() {
-          // User confirmed the deletion
-          var components = _.filter(Component['$' + vm.componentType], function(component) {
-            return component.selected;
-          });
-          Calendar.$deleteComponents(components).then(function() {
-            vm.mode.multiple = 0;
-            $rootScope.$emit('calendars:list');
+      var components = _.filter(Component['$' + vm.componentType], function(component) {
+        return component.selected;
+      });
+      if(components.length > 0)
+        Dialog.confirm(l('Warning'),
+                      l('Are you sure you want to delete the selected components?'),
+                      { ok: l('Delete') })
+          .then(function() {
+            // User confirmed the deletion
+            Calendar.$deleteComponents(components).then(function() {
+              vm.mode.multiple = 0;
+              $rootScope.$emit('calendars:list');
+            });
           });
-        });
     }
 
     function openEvent($event, event) {