Added ability to specify workspace path from frontend #3619
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Imo, it should be an option to allow changing the folder, and default to False |
|
@amanape is this PR still required or will your UI overhaul take care of this? |
|
@mamoodi No, my overhaul will not take care of this 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically we allow the settings on the frontend to include the path for the workspace to be mounted within the docker container.
This is very much still in a draft state, as I have not updated the UI for it yet (You can update the setting by editing the entry in local storage from within chrome). I am also a little worried about the security ramifications of this, and need to think about it from that perspective.