Change transform translation to use PxrUsdMayaXformStack, the same object used in usd plugin #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as well as changes to make the code more error-resistant
…ng code review notes from pixar)
...by precalculating and-reusing insertion indices. However, only build up these indices if neeeded
Conflicts: lib/AL_USDMaya/AL/usdmaya/Utils.cpp
|
fixed merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more flexible than the existing method, giving better-aligned axes / manipulators in many situations, particularly as more xforms ops are added, and deals smoothly with switching between a single pivot ("pivot") and dual pivots ("rotatePivot" / "scalePivot").