Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shortcuts): Add Shortcuts to Help Menu #1870

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

AmanNegi
Copy link
Contributor

  • Added option of shortcuts in help menu
  • Clicking on the shortcut leads to the Shortcuts.md file

Fix for Issue: #1761

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #1870 (ef43205) into main (7c3a823) will increase coverage by 0.55%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   37.11%   37.66%   +0.55%     
==========================================
  Files         434      434              
  Lines       20260    20269       +9     
==========================================
+ Hits         7519     7634     +115     
+ Misses      12741    12635     -106     
Flag Coverage Δ
appflowy 16.19% <0.00%> (+0.85%) ⬆️
appflowy_editor 78.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entation/widgets/float_bubble/question_bubble.dart 15.11% <0.00%> (-0.94%) ⬇️
...rvice/shortcut_event/built_in_shortcut_events.dart 98.05% <ø> (ø)
frontend/app_flowy/lib/core/network_monitor.dart 61.53% <0.00%> (-2.47%) ⬇️
frontend/app_flowy/lib/plugins/blank/blank.dart 91.66% <0.00%> (ø)
...owy/lib/plugins/grid/application/row/row_list.dart 0.00% <0.00%> (ø)
...owy/lib/workspace/application/app/app_service.dart 8.62% <0.00%> (ø)
...wy/lib/plugins/grid/application/row/row_cache.dart 0.00% <0.00%> (ø)
...y/lib/workspace/application/view/view_service.dart 0.00% <0.00%> (ø)
...plugins/grid/application/grid_data_controller.dart 0.00% <0.00%> (ø)
...plugins/grid/application/view/grid_view_cache.dart 0.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@MayurSMahajan MayurSMahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Aman! Thanks for contributing to AppFlowy. Make sure you follow the steps in this doc https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/translation#steps-to-modify-an-existing-translation to generate the LocaleKeys class, only then you will be able to access LocalKeys.questionBubble_shortcuts.tr().

After the build command you may want to restart the app.

@LucasXu0 LucasXu0 self-requested a review February 20, 2023 06:59
@AmanNegi
Copy link
Contributor Author

Hey there sorry I tried running those commands but unfortunately they result in more errors. After running those two commands I have several errors like the generated file is missing the fields.

As you can see here the generated file is missing these fields, even though no changes were made to them.
Screenshot from 2023-02-21 06-35-34

@MayurSMahajan
Copy link
Collaborator

I think after you do the flutter pub run easy_localization:generate -f keys -o locale_keys.g.dart -S assets/translations.
You should Clean+Rebuild All.

@AmanNegi
Copy link
Contributor Author

Hey there, I tried that but I am still facing the same issue. Any idea regarding what I could be doing wrong? If possible could you please check it by running at your end?

@LucasXu0
Copy link
Collaborator

Hey there, I tried that but I am still facing the same issue. Any idea regarding what I could be doing wrong? If possible could you please check it by running at your end?

Hey, @AmanNegi. You can just run sh ./scripts/generate_language_files.sh in the frontend directory to generate the language files.

# lucas.xu @ MacBook-Pro-6 in ~/Desktop/AppFlowy/frontend on git:main o [9:42:39]
$ sh ./scripts/generate_language_files.sh

@AmanNegi
Copy link
Contributor Author

Hey there, it also results in the same error.

@LucasXu0
Copy link
Collaborator

Hey, @AmanNegi. Just let me help to fix it.

@AmanNegi
Copy link
Contributor Author

Hey there, thanks a lot! Is there something I need to do from my end as of now?

@annieappflowy annieappflowy added the new feature New feature or request label Feb 27, 2023
@AmanNegi
Copy link
Contributor Author

Hey @LucasXu0

Do I need to do something in order to accept your change/commits? Or should I make the same changes in my code?
Please let me know as I am confused, this is my first time contributing. :)

@annieappflowy
Copy link
Collaborator

@AmanNegi , he's traveling. He should be able to get back to you by this week. Thanks for contributing! Hope your PR can get merged soon :D

@AmanNegi
Copy link
Contributor Author

Oh Great! I also hope it gets merged ;)

Thanks a lot

AmanNegi and others added 2 commits February 28, 2023 09:11
- Added option of shorcuts in help menu
- Clicking on the shortcut leads to the `Shortcuts.md` file
@LucasXu0
Copy link
Collaborator

Hey, @AmanNegi. I solved the conflicts and will merge this PR after the CI pass.

@LucasXu0 LucasXu0 merged commit 2451d31 into AppFlowy-IO:main Feb 28, 2023
@AmanNegi
Copy link
Contributor Author

@LucasXu0 Thanks a lot for helping me out 🙌

I want to contribute to this project further as well, could you tell me what I was doing wrong which was causing those errors in my local system?

Thanks a lot again 🙂🤗

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 2, 2023

Hey, @AmanNegi. I executed the below commands in the frontend directory to generate the language files.

# lucas.xu @ MacBook-Pro-6 in ~/Desktop/AppFlowy/frontend on git:main o [9:42:39]
$ sh ./scripts/generate_language_files.sh

Screenshot 2023-03-02 at 15 53 28

If you still run into this problem, just DM me on Discord.

@AmanNegi
Copy link
Contributor Author

AmanNegi commented Mar 2, 2023

Oh yeah Thanks, Running the script resolves the issues 🎉

Also, your theme looks cool😎

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 2, 2023

Also, your theme looks cool😎

😁 Here's the theme link. https://marketplace.visualstudio.com/items?itemName=RobbOwen.synthwave-vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants