Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessKit Disable Gifs: Apply to animated avatars #1130

Closed

Conversation

marcustyphoon
Copy link
Collaborator

Description

This applies AccessKit Disable Gifs to animated WebP user avatars.

(Needs some more testing and probably cleanup of the mini label code).

Testing steps

@marcustyphoon marcustyphoon marked this pull request as draft July 10, 2023 22:28
@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Jul 10, 2023

Ah, webp can be used to serve non-animated images. ex: https://www.tumblr.com/ex/722477112068587520.

(okay yeah picking elena's reblog there was just to make the joke)

anyway, I obviously don't even know if the "feature" that this addresses is intended. I am fairly sure that I can feature detect animated webp by reading the binary webp header (it looked very simple) if needed.

@marcustyphoon marcustyphoon marked this pull request as ready for review July 11, 2023 07:42
@marcustyphoon
Copy link
Collaborator Author

Animated webp avatars were confirmed to be unintended.

@marcustyphoon
Copy link
Collaborator Author

(Although some icons are still animated. I assumed there was an attempt made to un-animate them, and if I recall correctly that was confirmed to me by a staff member, but if this is not an ongoing process and some icons are stuck this way, maybe this should be merged anyway?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant