-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tweak: Hide the home/following notification badge #1154
New Tweak: Hide the home/following notification badge #1154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This tweak should precede the "Hide the activity notification badge" since the Home button precedes the Activity button
- Naming nitpicks
- We should match casing when referring to stuff like button labels, for clarity (do a markless quotation)
- Even though it is technically also a "notification" badge it doesn't notify about notifications, which makes me want to avoid using the word notification (wow that sounds insane when I spell it out like that)
"Hide the Home/Following unread badge"
"Hide the Activity notification badge"
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Is the name of this tweak actually accurate? I'm not familiar with the progression of where and in what A/B test branches these badges appear. Of course, if this is still up in the air it makes sense to me to leave it as-is; the code does hide both no matter whether they exist or not and we can always remove the unnecessary reference later. |
I think right now, badges only appear on Home, but maybe they still appear on Following for accounts whose default tab is For You. I dont have such an account to test with and I'm too lazy to make one. |
Description
Similar to the the tweak that hides the notification badge for activity, this adds one that hides the notification badge for new posts on your chronological dashboard (following feed/home button). I've wanted this for years, people assume the activity one does this already, and it's particularly relevant as people are using it as a specific criticism of the vertical nav layout.
I am actually... confused? because I currently only see the badge in question appearing in the vertical nav layout? But a) I remember wanting this for ages so it must have been a thing, and b) the linked discussion definitely implies that it was a thing very recently?
Resolves #1132.
Testing steps