Vanilla Video: Fix blank video on pause in Safari #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like even this doesn't completely solve the problem if Cleanfeed is affecting the video in question as well? |
|
Nope, it's definitely something more than just this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't know why this works. Someone please help.
This fixes an issue where, in Safari, pausing a video with Vanilla Videos on causes it to go white (or, if popped out, black). It does so by adjusting the DOM position of the Vanilla Videos video element one higher (outside the
videoContainerelement). Are there listeners on that element which do something weird? I have no idea.Testing steps