Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-update behavior: Remove all extension DOM elements #1553

Closed

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jul 18, 2024

Description

see #1550

Testing steps

@marcustyphoon marcustyphoon self-assigned this Sep 14, 2024
@marcustyphoon marcustyphoon changed the title remove most old dom elements on startup On-update behavior: Remove all extension DOM elements Sep 16, 2024
@marcustyphoon
Copy link
Collaborator Author

On reflection, places where this would be a problem unless we specifically declined to use dom() or added an argument to it or alternative util export whose result would not be removed on extension reboot:

  • Subtle Activity Mutual tweak, where we empty the contents of the real text node
  • AccessKit Disable GIFs, where we wrap tumblr elements
  • Collapsed Queue, where we wrap tumblr elements
  • Maybe Classic Search? I don't remember.

This would also do inconsistent things with, for example, Shorten Posts, which needs a class removal to undo part of its effect.

Going back to #451 (comment) as the best-so-far way to handle this.

@marcustyphoon marcustyphoon removed their assignment Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant