Tweaks: Improve contributed content tweak compatibility #1623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As noted in the linked issue, the "highlight contributed content" tweak looks like it applies a subtle color highlight to the relevant trail item, but it's actually overriding the background with the
follow
palette color, which generally has that effect on most palettes but isn't compatible with customization.This applies a low-opacity accent color instead. 7% matches more closely with the current color on the True Blue palette, but I like ~10% better in general.
I also tried
blue
instead ofaccent
.Most notably, though we override
accent
in Themed Posts, but we don't overrideblue
, soaccent
gives more stable results.In addition, this disables the tweak's effect entirely when Themed Posts' "Theme every reblog trail item individually" setting is enabled; I guess it could make sense not to do this since it'll still work when people have default blog themes? It seems like a lot of the time it would be pointless, though.
Resolves #873.
Testing steps
The "alternative color demo" commit demos a way to add a second color option and compare side-by-side; one can find a post with a decent reblog chain and shift-P through different palettes.