-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postblock: Make options UI items links if possible #719
base: master
Are you sure you want to change the base?
Conversation
Uhhhhhhh. Is this impossible now? Can you no longer go to a post on a blog given the blog UUID and post ID? |
Yeah, it looks to me like you can go to |
Shit, really? What happens if you do? (Mainly want to see if it ends up on a Redpop 404 page; if it does, my redirection code handling this is busted but can probably be fixed.) |
Oh, I guess that's a silly reason to abandon this; it can just look up the blog name via an API request before navigation. Well, not "just," actually, since we can't access apiFetch from a settings panel. But it's solvable. |
or jquery not being stupid
User-facing changes
Technical explanation
A map* of post ID -> blog UUID entries is stored as a separate storage entry, rather than migrating the blocked posts list to e.g. an array of
[id, ?uuid]
. You could definitely do the latter, but that kind of thing requires a bit of thinking to ensure you correctly migrate old entries and don't have race conditions.*I unapologetically call POJO records "maps." Sue me.
Issues this closes
discussion #402