Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Tags: Work correctly on non-NPF posts #969

Merged
merged 6 commits into from
Aug 20, 2023

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Feb 13, 2023

Description

This adds an alternative API endpoint call to Quick Tags on posts that we cannot ensure the NPF edit endpoint will work on. It uses the mass post editor endpoint, which should work on both legacy and NPF posts.

For discussion about which posts are NPF-compatible, see discord.com/channels/104051306309644288/327155782934200320/1074286553733533738.

Resolves #940 (most likely reason). Resolves #965. Resolves #1224.

Testing steps

@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Feb 13, 2023

- [ ] see if the mega editor endpoint changes tipping

@AprilSylph AprilSylph linked an issue Mar 13, 2023 that may be closed by this pull request
@marcustyphoon
Copy link
Collaborator Author

This next commit addresses the above comment and #1046, though I'm not sure if this is the ideal way to do so (vs, for example, making the mega editor error wrapped in { body: contentsGoHere }.

@marcustyphoon marcustyphoon marked this pull request as ready for review May 9, 2023 19:17
@marcustyphoon marcustyphoon added the bugfix Restores intended behavior label Aug 15, 2023
@marcustyphoon
Copy link
Collaborator Author

Besides the virtual scroller stuff, this is IMO a good priority, as the virtual scroller broke legacy XKit's Quick Tags and that seems like a great excuse to have people switch ahem, reason to ensure we have a good alternative.

Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
@marcustyphoon
Copy link
Collaborator Author

Now that I think about it, it's probably better not to mention legacy posts in the copy at all, considering that there is some ambiguity there.

@AprilSylph
Copy link
Owner

AprilSylph commented Aug 20, 2023

Eh, the copy is accurate. If we're displaying that message then it's definitely a legacy post, even if it doesn't display for all legacy types.

@marcustyphoon marcustyphoon merged commit fcf63cc into AprilSylph:master Aug 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Restores intended behavior
Projects
None yet
2 participants