kmlread: factor checkbox menu items

only difference was checked-or-not
ArduPilot · May 15, 2024 · a16dcb2 · a16dcb2
1 parent 729c4c1
commit a16dcb2
Showing 1 changed file with 7 additions and 14 deletions.
diff --git a/MAVProxy/modules/mavproxy_kmlread.py b/MAVProxy/modules/mavproxy_kmlread.py
@@ -392,20 +392,13 @@ def idle_task(self):
                 if layer.key.endswith('-text'):
                     continue
 
-                if layer.key in self.curlayers:
-                    self.menu.items.append(MPMenuCheckbox(
-                        layer.key,
-                        layer.key,
-                        '# kml toggle \"' + layer.key + '\"',
-                        checked=True,
-                    ))
-                else:
-                    self.menu.items.append(MPMenuCheckbox(
-                        layer.key,
-                        layer.key,
-                        '# kml toggle \"' + layer.key + '\"',
-                        checked=False,
-                    ))
+                checked = layer.key in self.curlayers
+                self.menu.items.append(MPMenuCheckbox(
+                    layer.key,
+                    layer.key,
+                    f'# kml toggle \"{layer.key}\"',
+                    checked=checked,
+                ))
             # and add the menu to the map popu menu
             self.module('map').add_menu(self.menu)
         self.menu_needs_refreshing = False