mavproxy_mode: use MAV_CMD_DO_REPOSITION for 'Fly To' #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this has the advantage that you don't need to be in guided mode to start the command. Prevents some clunky interactions between pilot and GCS operator as the vehicle does not need to be somewhere safe to loiter before the command can be safely issued.
peterbarker
force-pushed
the
pr/fly-to-is-reposition
branch
from
854fde0
to
d8b0609
Compare
|
my main concern is an accidental click when not in GUIDED mode. We could use confirm, like we now do for set home, but maybe we should confirm only if not currently in GUIDED? |
"Fly To" pops up an altitude box - if you cancel that dialogue box rather than giving it a value then the operation does nothing - the vehicle doesn't change modes or anything. I considered that confirmation enough :-) |
tridge
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has the advantage that you don't need to be in guided mode to start the command. Prevents some clunk interactions between pilot and GCS operator as the vehicle does not need to be somewhere safe to loiter before the command can be safely issued.
Tested Copter, Plane and Rover in SITL. Altitudes appear to be correct.