misseditor: Better mission command dropdown

[stephendade]

Fix for #1162.

Modifies the mission editor's "Command" dropdown to use a custom control (ListCtrl), which has a better layout and visible scrollbars.

Tested on WSL and Ubuntu 22:

@rmackay9 - I'd be interested if this works better for you.

[rmackay9]

Thank you so much!

[stephendade]

@rmackay9, would you be able to give this a test-drive? Mostly just to see if the GUI changes work for you.

I'll get @tridge or @peterbarker to do the actual code review.

[rmackay9]

Hi @stephendade,

Yes, I'll give this a test. I'm not very confident about building MAVproxy from source but I'll try.

[rmackay9]

Hi @stephendade,

I gave this a test and it is certainly better than master because I can actually get to the commands I'd like to add.

It is a bit weird though, sometimes when I click on an existing command and try to change it, the drop-down appears behind the wp editor. It also appeared to me that at least once the list of commands was not sorted alphabetically although I'm now having troubles reproducing this.

[stephendade]

It is a bit weird though, sometimes when I click on an existing command and try to change it, the drop-down appears behind the wp editor. It also appeared to me that at least once the list of commands was not sorted alphabetically although I'm now having troubles reproducing this.

I've managed to replicate this. It's a x11 vs Wayland issue again. @MichelleRos had similar issues and fixed it via putting GDK_BACKEND="x11" in ~\.bashrc and restarting.

I've confirmed if you do the same, it should fix the window focus issue.

[rmackay9]

@stephendade,

Yes, that's fixed it for me as well. I had to add "export GDK_BACKEND="x11"" to my ~/.bashrc file.

[peterbarker]

@stephendade I can reliably produce this assertion:

wx._core.wxAssertionError: C++ assertion "firstHandler != this" failed at ../src/common/wincmn.cpp(1461) in PopEventHandler(): cannot pop the wxWindow itself

The above exception was the direct cause of the following exception:

SystemError: _PyEval_EvalFrameDefault returned a result with an exception set

... by selecting a type which ArduPilot doesn't undertstand, writing waypoints then reading waypoints.

[stephendade]

@stephendade I can reliably produce this assertion:

wx._core.wxAssertionError: C++ assertion "firstHandler != this" failed at ../src/common/wincmn.cpp(1461) in PopEventHandler(): cannot pop the wxWindow itself

The above exception was the direct cause of the following exception:

SystemError: _PyEval_EvalFrameDefault returned a result with an exception set

... by selecting a type which ArduPilot doesn't undertstand, writing waypoints then reading waypoints.

Now fixed. It was a reference counting issue (see wxWidgets/Phoenix#627)

[peterbarker]

Merged, thanks!