Chat: feature to cancel active runs #1404
Conversation
|
Thanks for this, I've tested and found a few little issues but once you fix those up (and re-test yourself) then I'll re-test and get this merged in |
adityaomar3
force-pushed
the
cancel_active_run
branch
from
84943ce
to
c1bf4d2
Compare
adityaomar3
force-pushed
the
cancel_active_run
branch
from
c1bf4d2
to
6dcd566
Compare
|
HI! @rmackay9 take a look, I have updated the fixes as told, I tested it, You please take a test too, if there is any edge cases missing or changes needed. |
|
|
||
| if (self.latest_run.status == "cancelled"): | ||
| return "cancelled successfully" | ||
| elif reply_messages is None: |
There was a problem hiding this comment.
Not a blocker but the "elif" could be just an "if" because of the return one line higher
|
Thanks for this. By the way, for future PRs could you specify what testing has been done? This is helpful for the reviewer. I tested this and it works. I saw one bit of odd behaviour (see below) in which I cancelled a command, "arm and takeoff to 20m" and then successfully cancelled the command but then when I put in an innocuous command a moment later ("helo" <-- was meant to be "hello") it completed the cancelled command. I'm pretty sure this is an issue on the OpenAI side though and it didn't happen the next time. Let's just keep an eye on this potential issue. |
|
Sure @rmackay9 thanks for the review, next time onwards I will surely add testing cases, reports from my side for a better review and tests. Sometimes it does not cancel, maybe the reason is code latency, for some prompts(mostly in which function calling is not used) responses are generated by OpenAI very fast, while status being "in progress" when the code reaches cancel part it is already completed. |
| if (run_status != "completed" and run_status != "cancelled" and | ||
| run_status != "cancelling"): |
There was a problem hiding this comment.
| if (run_status != "completed" and run_status != "cancelled" and | |
| run_status != "cancelling"): | |
| if run_status not in ["completed", "cancelled", "cancelling"]: |
|
Merged, thanks! |
This PR adds a cancel feature to cancel the active run on Open AI, i.e. it helps cancelling the active prompt given by user.