Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "open next entry" shortcut (J) doesn't load the next set of entries when it gets to the bottom #1557

Closed
parnic opened this issue Sep 18, 2024 · 6 comments
Labels

Comments

@parnic
Copy link

parnic commented Sep 18, 2024

Describe the bug
When you have too many entries to be loaded at the same time and are navigating through them with the J shortcut, the next set of entries does not load once you reach the bottom and press J again. You must scroll down to force the next set to load (or use R to refresh) and then you can continue scrolling.

It looks like a bug when it happens because the sidebar shows more entries remaining despite the "next" button not going to the next entry.

To Reproduce
Steps to reproduce the behavior:

  1. Have a lot of unread entries (I'm not sure what the pagination limit is, but I've seen it with 100)
  2. Enable Expanded display mode
  3. Proceed through each entry using the J key until you reach the end of the currently-loaded set
  4. Press J again, note that the next entry does not load/focus.
  5. Scroll down to load the next set of entries, note that J works now.

Expected behavior
Once I've advanced near the bottom of the list of loaded entries, the next set should load automatically so they're ready when I press J again. Alternatively, pressing J will trigger the load instead of having to scroll down (and ideally would focus/scroll to the next entry or loading indicator so I can tell it did something).

Screenshots

Environment (please complete the following information):

  • commafeed.com or self-hosted: self-hosted
  • If self-hosted, CommaFeed version [e.g. 5.1.0 (a3dcb2c)]: 5.1.1 (9a28bc7)
  • Browser [e.g. chrome, firefox]: Brave
  • Device [e.g. desktop, mobile]: Desktop (macOS)

Additional context

@Athou
Copy link
Owner

Athou commented Sep 18, 2024

Oh indeed, it seems to happens if the last entry is large enough to exceed the viewport height.
In that case, the bottom of the page is not yet reached so more entries are not loaded and pressing "j" does nothing.

I'll see what I can do, thanks!

@Athou Athou added the bug label Sep 18, 2024
@parnic
Copy link
Author

parnic commented Sep 18, 2024

Ah, yes, the height of the entry is important. Sorry for failing to mention that in the report.

Thank you for looking into it!

Athou added a commit that referenced this issue Sep 18, 2024
@Athou
Copy link
Owner

Athou commented Sep 18, 2024

I added a fix for this, do you mind testing it with one of the binaries from this CI build or the master-<database> docker tag?

@parnic
Copy link
Author

parnic commented Sep 18, 2024

Verified with the master-postgresql docker tag, v 5.1.1 (191574d).

Thanks!

@Athou
Copy link
Owner

Athou commented Sep 18, 2024

Thank you, I'll release a new version with the fix tonight!

@Athou Athou closed this as completed Sep 18, 2024
@Athou
Copy link
Owner

Athou commented Sep 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants