init

fix: fixing private voting by correctly throwing an error if simulation fails (#7840)

This PR makes a simulation of a tx fail, if the tx cannot be included in
a block and added to the state.

e.g. If a simulation produces duplicate nullifiers, or nullifiers that
already exist in a state tree, the results of this simulation should not
be returned, but should warn users that the transaction simulated is
impossible to actually be added to a block due to being an invalid
transaction.

The method for achieving the above is that a new API on the node was
created, used for validating the correctness of the metadata and
side-effects produced by a transaction. A transaction is deemed valid if
and only if the transaction can be added to a block that can be used to
advance state.

Note: this update does not make this validation necessary, and defaults
to offline simulation. Offline simulation is previous non-validated
behavior, and is potentially useful if we ever move to a model where a
node is optional to a pxe.

Another note just for reference: there is weirdness in e2e_prover, that
fails the proof validation.

Resolves #4781.

Apply suggestions from code review

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

yarn-project/aztec-node/package.json

@@ -25,11 +25,9 @@
     "../package.common.json"
   ],
   "jest": {
-    "moduleNameMapper": {
-      "^(\\.{1,2}/.*)\\.[cm]?js$": "$1"
-    },
-    "testRegex": "./src/.*\\.test\\.(js|mjs|ts)$",
-    "rootDir": "./src",
+    "extensionsToTreatAsEsm": [
+      ".ts"
+    ],
     "transform": {
       "^.+\\.tsx?$": [
         "@swc/jest",
@@ -43,9 +41,11 @@
         }
       ]
     },
-    "extensionsToTreatAsEsm": [
-      ".ts"
-    ],
+    "moduleNameMapper": {
+      "^(\\.{1,2}/.*)\\.[cm]?js$": "$1"
+    },
+    "testRegex": "./src/.*\\.test\\.(js|mjs|ts)$",
+    "rootDir": "./src",
     "reporters": [
       [
         "default",
@@ -83,6 +83,7 @@
     "@types/jest": "^29.5.0",
     "@types/node": "^18.7.23",
     "jest": "^29.5.0",
+    "jest-mock-extended": "^3.0.3",
     "ts-node": "^10.9.1",
     "typescript": "^5.0.4"
   },

yarn-project/aztec-node/src/aztec-node/config.ts

@@ -10,7 +10,7 @@ import { readFileSync } from 'fs';
 import { dirname, resolve } from 'path';
 import { fileURLToPath } from 'url';
 
-export { sequencerClientConfigMappings, SequencerClientConfig } from '@aztec/sequencer-client';
+export { sequencerClientConfigMappings, SequencerClientConfig };
 
 /**
  * The configuration the aztec node.

yarn-project/aztec-node/src/aztec-node/server.test.ts

@@ -0,0 +1,216 @@
+import { TestCircuitVerifier } from '@aztec/bb-prover';
+import {
+  type AztecNode,
+  type L1ToL2MessageSource,
+  type L2BlockSource,
+  type L2LogsSource,
+  MerkleTreeId,
+  type MerkleTreeOperations,
+  mockTxForRollup,
+} from '@aztec/circuit-types';
+import { AztecAddress, EthAddress, Fr, GasFees, GlobalVariables, MaxBlockNumber } from '@aztec/circuits.js';
+import { type AztecLmdbStore } from '@aztec/kv-store/lmdb';
+import { type P2P } from '@aztec/p2p';
+import { type GlobalVariableBuilder } from '@aztec/sequencer-client';
+import { NoopTelemetryClient } from '@aztec/telemetry-client/noop';
+import { type ContractDataSource } from '@aztec/types/contracts';
+import { type WorldStateSynchronizer } from '@aztec/world-state';
+
+import { type MockProxy, mock, mockFn } from 'jest-mock-extended';
+
+import { type AztecNodeConfig, getConfigEnvVars } from './config.js';
+import { AztecNodeService } from './server.js';
+
+describe('aztec node', () => {
+  let p2p: MockProxy<P2P>;
+  let globalVariablesBuilder: MockProxy<GlobalVariableBuilder>;
+  let merkleTreeOps: MockProxy<MerkleTreeOperations>;
+
+  let lastBlockNumber: number;
+
+  let node: AztecNode;
+
+  const chainId = new Fr(12345);
+  const version = Fr.ZERO;
+  const coinbase = EthAddress.random();
+  const feeRecipient = AztecAddress.random();
+  const gasFees = GasFees.empty();
+
+  beforeEach(() => {
+    lastBlockNumber = 0;
+
+    p2p = mock<P2P>();
+
+    globalVariablesBuilder = mock<GlobalVariableBuilder>();
+    merkleTreeOps = mock<MerkleTreeOperations>();
+
+    const worldState = mock<WorldStateSynchronizer>({
+      getLatest: () => merkleTreeOps,
+    });
+
+    const l2BlockSource = mock<L2BlockSource>({
+      getBlockNumber: mockFn().mockResolvedValue(lastBlockNumber),
+    });
+
+    const l2LogsSource = mock<L2LogsSource>();
+
+    const l1ToL2MessageSource = mock<L1ToL2MessageSource>();
+
+    // all txs use the same allowed FPC class
+    const contractSource = mock<ContractDataSource>();
+
+    const store = mock<AztecLmdbStore>();
+
+    const aztecNodeConfig: AztecNodeConfig = getConfigEnvVars();
+
+    node = new AztecNodeService(
+      {
+        ...aztecNodeConfig,
+        l1Contracts: {
+          ...aztecNodeConfig.l1Contracts,
+          rollupAddress: EthAddress.ZERO,
+          registryAddress: EthAddress.ZERO,
+          inboxAddress: EthAddress.ZERO,
+          outboxAddress: EthAddress.ZERO,
+          availabilityOracleAddress: EthAddress.ZERO,
+        },
+      },
+      p2p,
+      l2BlockSource,
+      l2LogsSource,
+      l2LogsSource,
+      contractSource,
+      l1ToL2MessageSource,
+      worldState,
+      undefined,
+      31337,
+      1,
+      globalVariablesBuilder,
+      store,
+      new TestCircuitVerifier(),
+      new NoopTelemetryClient(),
+    );
+  });
+
+  describe('tx validation', () => {
+    it('tests that the node correctly validates double spends', async () => {
+      const txs = [mockTxForRollup(0x10000), mockTxForRollup(0x20000)];
+      txs.forEach(tx => {
+        tx.data.constants.txContext.chainId = chainId;
+      });
+      const doubleSpendTx = txs[0];
+      const doubleSpendWithExistingTx = txs[1];
+
+      const mockedGlobalVariables = new GlobalVariables(
+        chainId,
+        version,
+        new Fr(lastBlockNumber + 1),
+        new Fr(1),
+        Fr.ZERO,
+        coinbase,
+        feeRecipient,
+        gasFees,
+      );
+
+      globalVariablesBuilder.buildGlobalVariables
+        .mockResolvedValueOnce(mockedGlobalVariables)
+        .mockResolvedValueOnce(mockedGlobalVariables);
+
+      expect(await node.isValidTx(doubleSpendTx)).toBe(true);
+
+      // We push a duplicate nullifier that was created in the same transaction
+      doubleSpendTx.data.forRollup!.end.nullifiers.push(doubleSpendTx.data.forRollup!.end.nullifiers[0]);
+
+      expect(await node.isValidTx(doubleSpendTx)).toBe(false);
+
+      globalVariablesBuilder.buildGlobalVariables
+        .mockResolvedValueOnce(mockedGlobalVariables)
+        .mockResolvedValueOnce(mockedGlobalVariables);
+
+      expect(await node.isValidTx(doubleSpendWithExistingTx)).toBe(true);
+
+      // We make a nullifier from `doubleSpendWithExistingTx` a part of the nullifier tree, so it gets rejected as double spend
+      const doubleSpendNullifier = doubleSpendWithExistingTx.data.forRollup!.end.nullifiers[0].toBuffer();
+      merkleTreeOps.findLeafIndex.mockImplementation((treeId: MerkleTreeId, value: any) => {
+        return Promise.resolve(
+          treeId === MerkleTreeId.NULLIFIER_TREE && value.equals(doubleSpendNullifier) ? 1n : undefined,
+        );
+      });
+
+      expect(await node.isValidTx(doubleSpendWithExistingTx)).toBe(false);
+    });
+
+    it('tests that the node correctly validates chain id', async () => {
+      const tx = mockTxForRollup(0x10000);
+      tx.data.constants.txContext.chainId = chainId;
+
+      const mockedGlobalVariables = new GlobalVariables(
+        chainId,
+        version,
+        new Fr(lastBlockNumber + 1),
+        new Fr(1),
+        Fr.ZERO,
+        coinbase,
+        feeRecipient,
+        gasFees,
+      );
+
+      globalVariablesBuilder.buildGlobalVariables
+        .mockResolvedValueOnce(mockedGlobalVariables)
+        .mockResolvedValueOnce(mockedGlobalVariables);
+
+      expect(await node.isValidTx(tx)).toBe(true);
+
+      // We make the chain id on the tx not equal to the configured chain id
+      tx.data.constants.txContext.chainId = new Fr(1n + chainId.value);
+
+      expect(await node.isValidTx(tx)).toBe(false);
+    });
+
+    it('tests that the node correctly validates max block numbers', async () => {
+      const txs = [mockTxForRollup(0x10000), mockTxForRollup(0x20000), mockTxForRollup(0x30000)];
+      txs.forEach(tx => {
+        tx.data.constants.txContext.chainId = chainId;
+      });
+
+      const noMaxBlockNumberMetadata = txs[0];
+      const invalidMaxBlockNumberMetadata = txs[1];
+      const validMaxBlockNumberMetadata = txs[2];
+
+      invalidMaxBlockNumberMetadata.data.forRollup!.rollupValidationRequests = {
+        maxBlockNumber: new MaxBlockNumber(true, new Fr(1)),
+        getSize: () => 1,
+        toBuffer: () => Fr.ZERO.toBuffer(),
+      };
+
+      validMaxBlockNumberMetadata.data.forRollup!.rollupValidationRequests = {
+        maxBlockNumber: new MaxBlockNumber(true, new Fr(5)),
+        getSize: () => 1,
+        toBuffer: () => Fr.ZERO.toBuffer(),
+      };
+
+      const mockedGlobalVariables = new GlobalVariables(
+        chainId,
+        version,
+        new Fr(lastBlockNumber + 5),
+        new Fr(1),
+        Fr.ZERO,
+        coinbase,
+        feeRecipient,
+        gasFees,
+      );
+
+      globalVariablesBuilder.buildGlobalVariables
+        .mockResolvedValueOnce(mockedGlobalVariables)
+        .mockResolvedValueOnce(mockedGlobalVariables)
+        .mockResolvedValueOnce(mockedGlobalVariables);
+
+      // Default tx with no max block number should be valid
+      expect(await node.isValidTx(noMaxBlockNumberMetadata)).toBe(true);
+      // Tx with max block number < current block number should be invalid
+      expect(await node.isValidTx(invalidMaxBlockNumberMetadata)).toBe(false);
+      // Tx with max block number >= current block number should be valid
+      expect(await node.isValidTx(validMaxBlockNumberMetadata)).toBe(true);
+    });
+  });
+});

yarn-project/yarn.lock

@@ -167,6 +167,7 @@ __metadata:
     "@types/jest": ^29.5.0
     "@types/node": ^18.7.23
     jest: ^29.5.0
+    jest-mock-extended: ^3.0.3
     koa: ^2.14.2
     koa-router: ^12.0.0
     ts-node: ^10.9.1