fix: remove event selector from unencrypted log #7309

sklppy88 · 2024-07-03T12:51:22Z

Addresses #7198 and #6578.

sklppy88 · 2024-07-03T12:51:36Z

feat: add support for fieldable in events #7310
fix: remove event selector from unencrypted log #7309 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

AztecBot · 2024-07-03T13:32:14Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 521 (+694%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 60.5 (-66%)
l2_block_processing_time_in_ms (4): 1,198 (+59%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,800 (+1%)	1,582 (+1%)	742 (+5%)	776 (+1%)	795 (+2%)
proof_construction_time_sha256_30_ms	12,138 (+2%)	3,358 (+6%)	1,555 (+10%)	1,511 (+5%)	1,540 (+5%)
proof_construction_time_sha256_100_ms	44,006	12,160 (+3%)	5,716 (+5%)	5,717 (+5%)	5,569 (+4%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0 (-2%)	88.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,522	415 (-1%)	201	229 (+2%)	268
proof_construction_time_poseidon_hash_100_ms	5,780	1,565	721 (-1%)	780 (-1%)	793 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,476	9,470	9,464
l1_rollup_execution_gas	611,215	611,360	611,505
l2_block_processing_time_in_ms	⚠️ 1,198 (+59%)	1,446 (+1%)	2,684 (-1%)
l2_block_building_time_in_ms	21,003	42,016	82,433
l2_block_rollup_simulation_time_in_ms	21,003	42,016	82,433
l2_block_public_tx_process_time_in_ms	17,973	38,782	79,237

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,216 (+1%)	10,049 (+1%)
node_database_size_in_bytes	12,431,440 (+1%)	16,179,280
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	103 (+1%)	410 (+1%)	11,878 (-1%)	19,482	54,134	73,920	2,243	524,288
private-kernel-inner	310	835 (+3%)	45,615	80,694	54,134	73,920	2,243	2,097,152
private-kernel-tail	1,088 (-1%)	2,606	44,378 (-1%)	61,457	62,057	14,912	399	2,097,152
base-parity	6.28 (+1%)	1,587 (-2%)	2,467	128	64.0	2,208	2.00	131,072
root-parity	49.3	55.9 (-1%)	33,821	27,100	64.0	2,720	18.0	2,097,152
base-rollup	6,623	5,037 (-1%)	76,518 (+1%)	170,330	728	3,648	47.0	4,194,304
root-rollup	112 (-3%)	70.0 (-3%)	19,377 (+1%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	539	2,362 (+1%)	36,612 (+1%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	504	3,343 (+1%)	37,581 (+1%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,154	25,474 (+13%)	152,045 (+1%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	469	1,152	28,999	109,233	54,134	73,920	2,243	1,048,576
public-kernel-teardown	490	3,383 (+2%)	37,606 (-1%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.5 (+1%)	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,837 (-1%)	47,317 (-1%)	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	8,792	412 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	8,792	39.6	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	8,792	1,208	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	8,792	932 (+2%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	8,792	500	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	8,792	1,639	14,720	49,236 (-1%)	2,097,152	393
Token:privately_mint_private_note	1,280	8,792	661 (+2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	8,792	289 (-3%)	14,720	11,023	524,288	393
Token:transfer	1,312	8,792	1,849 (-2%)	14,720	12,620	524,288	393
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,598 (+1%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	3,054 (+4%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	3,814 (+3%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	3,087 (+8%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	18,512 (+4%)	N/A	N/A
Benchmarking:create_note	1,344	8,792	479	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	8,792	77.0 (+8%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	8,792	1,579 (+3%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	8,792	2,159 (+3%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	70.3 (+4%)	13,790
GasToken:set_portal	16.4 (+1%)	3,339
Token:constructor	93.3	23,692
FPC:constructor	64.0 (+2%)	13,592
GasToken:mint_public	53.3 (+1%)	10,158
Token:mint_public	⚠️ 521 (+694%)	19,034
Token:assert_minter_and_mint	⚠️ 60.5 (-66%)	12,925
AuthRegistry:set_authorized	32.3 (-2%)	7,812
FPC:prepare_fee	122 (+3%)	15,062
Token:transfer_public	43.3 (+9%)	31,218
FPC:pay_refund	138 (+6%)	25,260
Benchmarking:increment_balance	2,212	15,267
Token:_increase_public_balance	56.2 (-2%)	15,006
FPC:pay_refund_with_shielded_rebate	117 (+4%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.154 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.5	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.605	0.517	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.5 (-1%)	76.4 (+1%)	131	248 (+1%)	470
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.496 (-1%)	0.469 (+1%)	0.450	0.448 (+1%)	0.438
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.0	112	181 (-1%)	358 (+1%)	692
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.507	0.501	0.481	0.482	0.475
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.522	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,841

Transaction size based on fee payment method

| Metric | |
| - | |

LHerskind · 2024-07-03T21:39:45Z

noir-projects/aztec-nr/aztec/src/hash.nr

    }
    for i in 0..n {
-        hash_bytes[40 + i] = message_bytes[i];
+        hash_bytes[36 + i] = message_bytes[i];


Neat. If people want it they can put it into the message, I like 👍

LHerskind · 2024-07-03T21:57:52Z

yarn-project/archiver/src/archiver/kv_archiver_store/log_store.ts

-      if (results.length >= this.#logsMaxPageSize) {
-        maxLogsHit = true;
-        break;
+      if (!filter.contractAddress || log.contractAddress.equals(filter.contractAddress)) {


Not sure I would be updating how it looked here, as I think it would make sense for us to allow some filtering with a bit of regex on the raw bytes, but can be done later though, not something that seems like an actual high priority right in this moment 🤷 though seems fairly important to not require users to get every log for the address and then need to do filtering afterwards, we can use bandwidth better.

LHerskind · 2024-07-03T21:58:57Z

yarn-project/circuit-types/src/logs/unencrypted_l2_log.ts

    /** The data contents of the log. */
    public readonly data: Buffer,
  ) {}

  get length(): number {
    // TODO(6578): explain magic number 4 here
-    return EventSelector.SIZE + this.data.length + AztecAddress.SIZE_IN_BYTES + 4;
+    return this.data.length + AztecAddress.SIZE_IN_BYTES + 4;


While updating here, might as well add a small note on the 4 bytes and handle #6578 so it is not living forever.

Good idea, I wrote my interpretation and linked the issue comment.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.45.1</summary> ## [0.45.1](aztec-package-v0.45.0...aztec-package-v0.45.1) (2024-07-04) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.45.1</summary> ## [0.45.1](barretenberg.js-v0.45.0...barretenberg.js-v0.45.1) (2024-07-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.45.1</summary> ## [0.45.1](aztec-packages-v0.45.0...aztec-packages-v0.45.1) (2024-07-04) ### Features * Add support for fieldable in events ([#7310](#7310)) ([694cebc](694cebc)), closes [#6951](#6951) * **avm:** Use template engine for codegen ([#7299](#7299)) ([d4359a3](d4359a3)) * Build releases for `aarch64-unknown-linux-gnu` target (noir-lang/noir#5289) ([2ae17f2](2ae17f2)) * Create codeql.yml ([#7318](#7318)) ([11fcfd2](11fcfd2)) * Deploy l1 contracts on devnet ([#7306](#7306)) ([b8eef86](b8eef86)) * Implement trait dispatch in the comptime interpreter (noir-lang/noir#5376) ([ccfa69c](ccfa69c)) * Lsp "find all references" (noir-lang/noir#5395) ([10076d9](10076d9)) * Lsp rename struct (noir-lang/noir#5380) ([2ae17f2](2ae17f2)) * **lsp:** Allow function rename (noir-lang/noir#4294) ([ccfa69c](ccfa69c)) * Remove note hash nullifier counter. ([#7294](#7294)) ([c0c9144](c0c9144)) * Sync from aztec-packages (noir-lang/noir#5387) ([ccfa69c](ccfa69c)) * Sync from aztec-packages (noir-lang/noir#5401) ([10076d9](10076d9)) ### Bug Fixes * Correctly detect signed/unsigned integer overflows/underflows (noir-lang/noir#5375) ([10076d9](10076d9)) * **docs:** Fix broken docs link to gihtub (noir-lang/noir#5398) ([10076d9](10076d9)) * **docs:** Fix colour leak ([#7289](#7289)) ([d3388d4](d3388d4)) * Don't panic when using undefined variables in the interpreter (noir-lang/noir#5381) ([10076d9](10076d9)) * Go to definition from `use` statement (noir-lang/noir#5390) ([2ae17f2](2ae17f2)) * Go to definition from aliased use (noir-lang/noir#5396) ([10076d9](10076d9)) * ICE when using a comptime let variable in runtime code (noir-lang/noir#5391) ([10076d9](10076d9)) * Include artifacts in noir-contracts package.json ([#7339](#7339)) ([7dd87c7](7dd87c7)) * Only create d.ts files for contract artifacts ([#7307](#7307)) ([b5e2a67](b5e2a67)) * Remove event selector from unencrypted log ([#7309](#7309)) ([c6eb734](c6eb734)) * Remove panics in the interpreter when a builtin fails to type check (noir-lang/noir#5382) ([ccfa69c](ccfa69c)) * Replace expects in interpreter with errors (noir-lang/noir#5383) ([ccfa69c](ccfa69c)) * Replace std::HashMap with FxHashMap to fix frontend indeterminism (noir-lang/noir#5385) ([ccfa69c](ccfa69c)) * Truncate flamegraph text to the right ([#7333](#7333)) ([b7c6593](b7c6593)) ### Miscellaneous * Add bb-pilcom to rust analyzer ([#7317](#7317)) ([694e68e](694e68e)) * ARGS_HASH constants 64 -> 16 ([#7284](#7284)) ([c19029a](c19029a)) * **avm:** Basic stat collection ([#7283](#7283)) ([adf2331](adf2331)) * **avm:** Less code in prover and verifier ([#7302](#7302)) ([f401a9a](f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](#7335)) ([56fe4fe](56fe4fe)) * **avm:** Migrate to template engine ([#7316](#7316)) ([0fbfe11](0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](#7298)) ([4bb512d](4bb512d)) * **avm:** Remove shifts from full row ([#7327](#7327)) ([4d641ee](4d641ee)) * Charge for more l2 gas costs ([#7157](#7157)) ([3ab00c4](3ab00c4)) * **docs:** Remove persona boxes from the landing page (noir-lang/noir#5400) ([10076d9](10076d9)) * Nuking "new" from names ([#7273](#7273)) ([b12c6cb](b12c6cb)) * Refactor conversion between `FieldElement` and signed integers (noir-lang/noir#5397) ([10076d9](10076d9)) * Replace relative paths to noir-protocol-circuits ([0124665](0124665)) * Replace relative paths to noir-protocol-circuits ([4007885](4007885)) * Update flamegraph script link ([#7329](#7329)) ([0ec83ee](0ec83ee)) * Use `mod.nr` files in stdlib (noir-lang/noir#5379) ([ccfa69c](ccfa69c)) </details> <details><summary>barretenberg: 0.45.1</summary> ## [0.45.1](barretenberg-v0.45.0...barretenberg-v0.45.1) (2024-07-04) ### Features * **avm:** Use template engine for codegen ([#7299](#7299)) ([d4359a3](d4359a3)) ### Miscellaneous * **avm:** Basic stat collection ([#7283](#7283)) ([adf2331](adf2331)) * **avm:** Less code in prover and verifier ([#7302](#7302)) ([f401a9a](f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](#7335)) ([56fe4fe](56fe4fe)) * **avm:** Migrate to template engine ([#7316](#7316)) ([0fbfe11](0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](#7298)) ([4bb512d](4bb512d)) * **avm:** Remove shifts from full row ([#7327](#7327)) ([4d641ee](4d641ee)) * Nuking "new" from names ([#7273](#7273)) ([b12c6cb](b12c6cb)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@aztec-package-v0.45.0...aztec-package-v0.45.1) (2024-07-04) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@barretenberg.js-v0.45.0...barretenberg.js-v0.45.1) (2024-07-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@aztec-packages-v0.45.0...aztec-packages-v0.45.1) (2024-07-04) ### Features * Add support for fieldable in events ([#7310](AztecProtocol/aztec-packages#7310)) ([694cebc](AztecProtocol/aztec-packages@694cebc)), closes [#6951](AztecProtocol/aztec-packages#6951) * **avm:** Use template engine for codegen ([#7299](AztecProtocol/aztec-packages#7299)) ([d4359a3](AztecProtocol/aztec-packages@d4359a3)) * Build releases for `aarch64-unknown-linux-gnu` target (noir-lang/noir#5289) ([2ae17f2](AztecProtocol/aztec-packages@2ae17f2)) * Create codeql.yml ([#7318](AztecProtocol/aztec-packages#7318)) ([11fcfd2](AztecProtocol/aztec-packages@11fcfd2)) * Deploy l1 contracts on devnet ([#7306](AztecProtocol/aztec-packages#7306)) ([b8eef86](AztecProtocol/aztec-packages@b8eef86)) * Implement trait dispatch in the comptime interpreter (noir-lang/noir#5376) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Lsp "find all references" (noir-lang/noir#5395) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Lsp rename struct (noir-lang/noir#5380) ([2ae17f2](AztecProtocol/aztec-packages@2ae17f2)) * **lsp:** Allow function rename (noir-lang/noir#4294) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Remove note hash nullifier counter. ([#7294](AztecProtocol/aztec-packages#7294)) ([c0c9144](AztecProtocol/aztec-packages@c0c9144)) * Sync from aztec-packages (noir-lang/noir#5387) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Sync from aztec-packages (noir-lang/noir#5401) ([10076d9](AztecProtocol/aztec-packages@10076d9)) ### Bug Fixes * Correctly detect signed/unsigned integer overflows/underflows (noir-lang/noir#5375) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * **docs:** Fix broken docs link to gihtub (noir-lang/noir#5398) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * **docs:** Fix colour leak ([#7289](AztecProtocol/aztec-packages#7289)) ([d3388d4](AztecProtocol/aztec-packages@d3388d4)) * Don't panic when using undefined variables in the interpreter (noir-lang/noir#5381) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Go to definition from `use` statement (noir-lang/noir#5390) ([2ae17f2](AztecProtocol/aztec-packages@2ae17f2)) * Go to definition from aliased use (noir-lang/noir#5396) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * ICE when using a comptime let variable in runtime code (noir-lang/noir#5391) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Include artifacts in noir-contracts package.json ([#7339](AztecProtocol/aztec-packages#7339)) ([7dd87c7](AztecProtocol/aztec-packages@7dd87c7)) * Only create d.ts files for contract artifacts ([#7307](AztecProtocol/aztec-packages#7307)) ([b5e2a67](AztecProtocol/aztec-packages@b5e2a67)) * Remove event selector from unencrypted log ([#7309](AztecProtocol/aztec-packages#7309)) ([c6eb734](AztecProtocol/aztec-packages@c6eb734)) * Remove panics in the interpreter when a builtin fails to type check (noir-lang/noir#5382) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Replace expects in interpreter with errors (noir-lang/noir#5383) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Replace std::HashMap with FxHashMap to fix frontend indeterminism (noir-lang/noir#5385) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Truncate flamegraph text to the right ([#7333](AztecProtocol/aztec-packages#7333)) ([b7c6593](AztecProtocol/aztec-packages@b7c6593)) ### Miscellaneous * Add bb-pilcom to rust analyzer ([#7317](AztecProtocol/aztec-packages#7317)) ([694e68e](AztecProtocol/aztec-packages@694e68e)) * ARGS_HASH constants 64 -> 16 ([#7284](AztecProtocol/aztec-packages#7284)) ([c19029a](AztecProtocol/aztec-packages@c19029a)) * **avm:** Basic stat collection ([#7283](AztecProtocol/aztec-packages#7283)) ([adf2331](AztecProtocol/aztec-packages@adf2331)) * **avm:** Less code in prover and verifier ([#7302](AztecProtocol/aztec-packages#7302)) ([f401a9a](AztecProtocol/aztec-packages@f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](AztecProtocol/aztec-packages#7335)) ([56fe4fe](AztecProtocol/aztec-packages@56fe4fe)) * **avm:** Migrate to template engine ([#7316](AztecProtocol/aztec-packages#7316)) ([0fbfe11](AztecProtocol/aztec-packages@0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](AztecProtocol/aztec-packages#7298)) ([4bb512d](AztecProtocol/aztec-packages@4bb512d)) * **avm:** Remove shifts from full row ([#7327](AztecProtocol/aztec-packages#7327)) ([4d641ee](AztecProtocol/aztec-packages@4d641ee)) * Charge for more l2 gas costs ([#7157](AztecProtocol/aztec-packages#7157)) ([3ab00c4](AztecProtocol/aztec-packages@3ab00c4)) * **docs:** Remove persona boxes from the landing page (noir-lang/noir#5400) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Nuking "new" from names ([#7273](AztecProtocol/aztec-packages#7273)) ([b12c6cb](AztecProtocol/aztec-packages@b12c6cb)) * Refactor conversion between `FieldElement` and signed integers (noir-lang/noir#5397) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Replace relative paths to noir-protocol-circuits ([0124665](AztecProtocol/aztec-packages@0124665)) * Replace relative paths to noir-protocol-circuits ([4007885](AztecProtocol/aztec-packages@4007885)) * Update flamegraph script link ([#7329](AztecProtocol/aztec-packages#7329)) ([0ec83ee](AztecProtocol/aztec-packages@0ec83ee)) * Use `mod.nr` files in stdlib (noir-lang/noir#5379) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) </details> <details><summary>barretenberg: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@barretenberg-v0.45.0...barretenberg-v0.45.1) (2024-07-04) ### Features * **avm:** Use template engine for codegen ([#7299](AztecProtocol/aztec-packages#7299)) ([d4359a3](AztecProtocol/aztec-packages@d4359a3)) ### Miscellaneous * **avm:** Basic stat collection ([#7283](AztecProtocol/aztec-packages#7283)) ([adf2331](AztecProtocol/aztec-packages@adf2331)) * **avm:** Less code in prover and verifier ([#7302](AztecProtocol/aztec-packages#7302)) ([f401a9a](AztecProtocol/aztec-packages@f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](AztecProtocol/aztec-packages#7335)) ([56fe4fe](AztecProtocol/aztec-packages@56fe4fe)) * **avm:** Migrate to template engine ([#7316](AztecProtocol/aztec-packages#7316)) ([0fbfe11](AztecProtocol/aztec-packages@0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](AztecProtocol/aztec-packages#7298)) ([4bb512d](AztecProtocol/aztec-packages@4bb512d)) * **avm:** Remove shifts from full row ([#7327](AztecProtocol/aztec-packages#7327)) ([4d641ee](AztecProtocol/aztec-packages@4d641ee)) * Nuking "new" from names ([#7273](AztecProtocol/aztec-packages#7273)) ([b12c6cb](AztecProtocol/aztec-packages@b12c6cb)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sklppy88 mentioned this pull request Jul 3, 2024

feat: add support for fieldable in events #7310

Merged

sklppy88 changed the title ~~init~~ fix: remove event selector from unencrypted log Jul 3, 2024

sklppy88 force-pushed the ek/fix/7198/remove-event-selector-from-unencrypted-log branch 6 times, most recently from 84b7af1 to 3ae580d Compare July 3, 2024 17:09

sklppy88 marked this pull request as ready for review July 3, 2024 18:13

sklppy88 requested review from fcarreiro and dbanks12 as code owners July 3, 2024 18:13

sklppy88 requested a review from LHerskind July 3, 2024 18:13

sklppy88 linked an issue Jul 3, 2024 that may be closed by this pull request

fix(Event_Logs): Remove event selector from L2UnencryptedLog #7198

Closed

LHerskind approved these changes Jul 3, 2024

View reviewed changes

sklppy88 force-pushed the ek/fix/7198/remove-event-selector-from-unencrypted-log branch from 3ae580d to a82855c Compare July 4, 2024 00:28

sklppy88 linked an issue Jul 4, 2024 that may be closed by this pull request

chore: explain magic number 4 for unencrypted logs [hash] length #6578

Closed

init

ec18253

sklppy88 force-pushed the ek/fix/7198/remove-event-selector-from-unencrypted-log branch from a82855c to ec18253 Compare July 4, 2024 00:37

sklppy88 enabled auto-merge (squash) July 4, 2024 01:12

sklppy88 merged commit c6eb734 into master Jul 4, 2024
92 checks passed

sklppy88 deleted the ek/fix/7198/remove-event-selector-from-unencrypted-log branch July 4, 2024 01:18

AztecBot mentioned this pull request Jul 4, 2024

chore(master): Release 0.45.1 #7292

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove event selector from unencrypted log #7309

fix: remove event selector from unencrypted log #7309

sklppy88 commented Jul 3, 2024 •

edited

Loading

sklppy88 commented Jul 3, 2024

AztecBot commented Jul 3, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LHerskind Jul 3, 2024

LHerskind Jul 3, 2024

LHerskind Jul 3, 2024

sklppy88 Jul 4, 2024

fix: remove event selector from unencrypted log #7309

fix: remove event selector from unencrypted log #7309

Conversation

sklppy88 commented Jul 3, 2024 • edited Loading

sklppy88 commented Jul 3, 2024

AztecBot commented Jul 3, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LHerskind Jul 3, 2024

Choose a reason for hiding this comment

LHerskind Jul 3, 2024

Choose a reason for hiding this comment

LHerskind Jul 3, 2024

Choose a reason for hiding this comment

sklppy88 Jul 4, 2024

Choose a reason for hiding this comment

sklppy88 commented Jul 3, 2024 •

edited

Loading

AztecBot commented Jul 3, 2024 •

edited

Loading