feat: populate recipient in outgoing

[sklppy88]

Resolves #7177.

With this, we are adding recipient to the outgoing log. I'm adding it as another parameter to the emission, when we pass it in the normal circumstance (without keys), it is using the same value as the incoming viewer.

[sklppy88]

• fix: nuke app siloed incoming viewing keys #7464
• feat: populate recipient in outgoing #7390 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:assert_minter_and_mint): 83.1 (+69%)
• protocol_circuit_proving_time_in_ms (root-parity): 30,326 (-40%)
• protocol_circuit_proving_time_in_ms (public-kernel-setup): 17,410 (-21%)
• protocol_circuit_proving_time_in_ms (public-kernel-teardown): 17,969 (-21%)
• protocol_circuit_proving_time_in_ms (root-rollup): 30,094 (-26%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,615 (+4%)	1,504 (+2%)	674 (+1%)	732 (+1%)	748 (+3%)
proof_construction_time_sha256_30_ms	11,173 (+3%)	3,021 (+2%)	1,320 (+1%)	1,346 (-2%)	1,395
proof_construction_time_sha256_100_ms	42,154 (+1%)	11,552 (+2%)	5,574 (+10%)	5,530 (-3%)	5,129 (+1%)
proof_construction_time_poseidon_hash_ms	75.0	34.0	34.0	58.0 (+2%)	92.0 (+3%)
proof_construction_time_poseidon_hash_30_ms	1,463 (+1%)	406 (+1%)	195 (+1%)	222 (+4%)	260 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,560 (+4%)	1,488 (+2%)	654 (+2%)	729 (+6%)	721 (+2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,588	6,596	6,600
l1_rollup_execution_gas	583,050	583,209	583,364
l2_block_processing_time_in_ms	801 (-1%)	1,493 (-1%)	2,885 (-1%)
l2_block_building_time_in_ms	13,649 (-1%)	26,927	52,663 (-1%)
l2_block_rollup_simulation_time_in_ms	13,649 (-1%)	26,927	52,663 (-1%)
l2_block_public_tx_process_time_in_ms	11,428 (-1%)	24,510	50,234 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,438 (-1%)	10,338 (-1%)
node_database_size_in_bytes	12,419,152	16,437,328
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	120 (-1%)	397	21,732	54,085	N/A	N/A	N/A	N/A
private-kernel-inner	232 (-2%)	701 (-1%)	81,199	54,264	N/A	N/A	N/A	N/A
private-kernel-tail	1,117 (-2%)	2,480 (-1%)	61,808	61,554	N/A	N/A	N/A	N/A
base-parity	6.71 (-1%)	809 (-6%)	160	96.0	1,955 (-2%)	12,676	3.00	131,072
root-parity	111	118 (+1%)	64,860	96.0	⚠️ 30,326 (-40%)	12,676	3.00	4,194,304
base-rollup	4,335 (-1%)	4,831 (-2%)	180,315	632	42,940 (-12%)	13,476	28.0	4,194,304
root-rollup	160 (-1%)	128 (+6%)	51,261	652	⚠️ 30,094 (-26%)	13,412	26.0	4,194,304
public-kernel-setup	194 (-5%)	2,371 (-3%)	112,536	80,310	⚠️ 17,410 (-21%)	118,916	3,323	2,097,152
public-kernel-app-logic	153 (-1%)	3,293 (+1%)	112,536	80,310	10,065	118,916	3,323	1,048,576
public-kernel-tail	914 (-1%)	25,843 (-5%)	409,413	10,046	66,316 (-9%)	24,868	384	8,388,608
private-kernel-reset-tiny	307 (-1%)	983 (-2%)	77,007	53,954	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	6,741 (-1%)	2,940 (+4%)	777,415	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	139 (-4%)	3,242 (-1%)	112,536	80,310	⚠️ 17,969 (-21%)	118,916	3,323	2,097,152
merge-rollup	59.9 (-2%)	N/A	33,566	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	163,031 (+1%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	9,344	413 (+1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	26.1	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	655	N/A	N/A
GasToken:deploy	1,344	9,344	578 (-2%)	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	458	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	811 (-1%)	N/A	N/A
Token:privately_mint_private_note	1,248	9,344	520 (-1%)	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	105 (+2%)	N/A	N/A
Token:transfer	1,280	9,344	1,525 (-1%)	N/A	N/A
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	95,392	2,078 (-2%)
FPC:prepare_fee (avm)	26,664	N/A	N/A	95,456	2,755 (-2%)
Token:transfer_public (avm)	42,914	N/A	N/A	95,456	3,155 (-1%)
AuthRegistry:consume (avm)	33,100	N/A	N/A	95,424	2,734 (-3%)
FPC:pay_refund (avm)	36,829	N/A	N/A	95,424	10,881 (-1%)
Benchmarking:create_note	1,312	9,344	465 (-1%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	44.8 (-3%)	N/A	N/A
Token:unshield	1,344	9,344	1,250 (-3%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,632 (-2%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	98.8	13,790
GasToken:set_portal	15.5 (+20%)	3,339
Token:constructor	122 (-5%)	23,692
FPC:constructor	94.2 (+3%)	13,592
GasToken:mint_public	82.0	10,158
Token:mint_public	325 (-7%)	19,034
Token:assert_minter_and_mint	⚠️ 83.1 (+69%)	12,925
AuthRegistry:set_authorized	47.5 (-2%)	7,812
FPC:prepare_fee	129 (+7%)	15,062
Token:transfer_public	30.7 (-29%)	31,218
FPC:pay_refund	132 (+3%)	25,260
Benchmarking:increment_balance	1,390	15,267
Token:_increase_public_balance	15.7 (-14%)	15,006
FPC:pay_refund_with_shielded_rebate	191 (-5%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.152 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.8	17.4	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.625	0.536	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	50.1	80.5	139 (-1%)	261	503
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.513	0.495	0.479	0.473	0.469
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	62.1 (-1%)	118 (-1%)	195 (-1%)	375	739 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.525 (-1%)	0.528 (-1%)	0.516 (+1%)	0.508	0.507
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	76.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.545	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	76,837	667,838

Transaction size based on fee payment method

| Metric | |
| - | |

[nventuro]

Not extremely familiar with this side of keys, but there doesn't seem to be anything fancy going on here regardless.