Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: structured commit #9027

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

feat: structured commit #9027

wants to merge 31 commits into from
+857 −27

Conversation

ledwards2225
Copy link
Contributor

Please read contributing guidelines and remove this line.

@ledwards2225 ledwards2225 marked this pull request as ready for review October 4, 2024 15:57
@ledwards2225
fix wasm build
3e07e45
@ledwards2225
fix comment block
4c1cee3
@ledwards2225
delegate sub algos to reusable methods
74aa071
@ledwards2225
wow the test passes with the new z perm method
0a82bf3
@ledwards2225
bug fix; realistic test passes for z_perm
a2e2246
@ledwards2225
batched addition isolated in new class
6cc6c70
@ledwards2225
parallel batch add passes tests and bench is very promising
c781afd
@ledwards2225
outer class manages mem and innner class is static
d644404
@ledwards2225
working method for distribution of points across threads
8029501
@ledwards2225
functioning method for constructing thread data
beae61a
@ledwards2225
qucik update
a985f1a
@ledwards2225
full batched add parallel method passes test
5b2023c
@ledwards2225
standalone test for batched addition
4f23262
@ledwards2225
realistic zperm commit test passing with CK method
2f7edea
@ledwards2225
make it build
c242d29
@ledwards2225
bench cleanup
5854d13
@ledwards2225
correctly dynamically determine number of threads
d64c8d9
@ledwards2225
cleanup; bench shows 50 pct reduction for zperm
3e0c5ac
@ledwards2225
cleanup
064058d
@ledwards2225
reorg batched affine add class
b150ed3
@ledwards2225
test suite cleanup
a48eac8
@ledwards2225
cleanup comment and reorg
fedbdbb
@ledwards2225
Merge branch 'master' into lde/structured_commit
6b7c824
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Changes to circuit sizes

Generated at commit: aed7c05a09345cd4f1187e374b88154ac665f9a8, compared to commit: 4d1f7d83f9d14b1df70a26c99f696aebd0416ebd

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base +188,715 ❌ +39.06% +170,257 ❌ +5.07%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base 671,888 (+188,715) +39.06% 3,525,994 (+170,257) +5.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ledwards2225