fix: allow passing rayon threads when building aztec images #9096
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not do parallel vk generation for mock circuits
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Maddiaa0
reviewed
Oct 8, 2024
yarn-project/Earthfile
Outdated
| @@ -36,7 +36,7 @@ build: | |||
| BUILD ../barretenberg/cpp/+build | |||
| BUILD ../barretenberg/ts/+build | |||
| BUILD ../noir/+nargo | |||
| BUILD ../noir-projects/+build | |||
| BUILD ../noir-projects/+build --RAYON_NUM_THREADS=$RAYON_NUM_THREADS | |||
There was a problem hiding this comment.
damn it really be like that huh
There was a problem hiding this comment.
Ah yeah I guess they are only automatically passed in the same earthfile, annoying caveat
There was a problem hiding this comment.
Might be cleaner to use --pass-args
I just ran `earthly build ./yarn-project/+export-e2e-test-images` on this branch and got threads at 1
|
You still need to set |
ludamad
approved these changes
Oct 9, 2024
spalladino
reviewed
Oct 9, 2024
| for pathname in "./target"/*.json; do | ||
| BB_HASH=$BB_HASH node ../scripts/generate_vk_json.js "$pathname" "./target/keys" | ||
| done | ||
| fi | ||
|
|
||
| for job in $(jobs -p); do | ||
| wait $job || exit 1 |
There was a problem hiding this comment.
Do we need this when running sequentially?
There was a problem hiding this comment.
No, indeed. I missed this bit. Shouldn't hurt though.
| @@ -56,11 +56,10 @@ build-mock-protocol-circuits: | |||
|
|
|||
| ENV RAYON_NUM_THREADS=$RAYON_NUM_THREADS | |||
| RUN echo "building with num threads $RAYON_NUM_THREADS" | |||
| RUN cd mock-protocol-circuits && BB_HASH=$bb_source_hash NARGO=nargo ./bootstrap.sh | |||
| RUN cd mock-protocol-circuits && BB_HASH=$bb_source_hash NARGO=nargo PARALLEL_VK=false ./bootstrap.sh | |||
There was a problem hiding this comment.
We never want to build in parallel here?
There was a problem hiding this comment.
No. For some reason, when it is in container (bootstrap_docker or earthly) parallel generation gives non-deterministic errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, do not do parallel vk generation for mock circuits