Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce SRS size back to normal #9098

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −11
Draft

fix: Reduce SRS size back to normal #9098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions barretenberg/cpp/src/barretenberg/ecc/scalar_multiplication/scalar_multiplication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ template <typename Curve>
void compute_wnaf_states(uint64_t* point_schedule,
bool* input_skew_table,
uint64_t* round_counts,
const std::span<const typename Curve::ScalarField> scalars,
PolynomialSpan<const typename Curve::ScalarField> scalars,
const size_t num_initial_points)
{
using Fr = typename Curve::ScalarField;
Expand Down Expand Up @@ -876,7 +876,7 @@ typename Curve::Element evaluate_pippenger_rounds(pippenger_runtime_state<Curve>

template <typename Curve>
typename Curve::Element pippenger_internal(std::span<const typename Curve::AffineElement> points,
std::span<const typename Curve::ScalarField> scalars,
PolynomialSpan<const typename Curve::ScalarField> scalars,
const size_t num_initial_points,
pippenger_runtime_state<Curve>& state,
bool handle_edge_cases)
Expand All @@ -890,7 +890,7 @@ typename Curve::Element pippenger_internal(std::span<const typename Curve::Affin
}

template <typename Curve>
typename Curve::Element pippenger(std::span<const typename Curve::ScalarField> scalars,
typename Curve::Element pippenger(PolynomialSpan<const typename Curve::ScalarField> scalars,
std::span<const typename Curve::AffineElement> points,
pippenger_runtime_state<Curve>& state,
bool handle_edge_cases)
Expand Down Expand Up @@ -943,7 +943,7 @@ Pippenger above can behavely poorly with numbers with many bits set.*/

template <typename Curve>
typename Curve::Element pippenger_unsafe_optimized_for_non_dyadic_polys(
std::span<const typename Curve::ScalarField> scalars,
PolynomialSpan<const typename Curve::ScalarField> scalars,
std::span<const typename Curve::AffineElement> points,
pippenger_runtime_state<Curve>& state)
{
Expand Down Expand Up @@ -977,7 +977,7 @@ typename Curve::Element pippenger_unsafe_optimized_for_non_dyadic_polys(
*
**/
template <typename Curve>
typename Curve::Element pippenger_unsafe(std::span<const typename Curve::ScalarField> scalars,
typename Curve::Element pippenger_unsafe(PolynomialSpan<const typename Curve::ScalarField> scalars,
std::span<const typename Curve::AffineElement> points,
pippenger_runtime_state<Curve>& state)
{
Expand Down Expand Up @@ -1017,7 +1017,7 @@ template void evaluate_addition_chains<curve::BN254>(affine_product_runtime_stat
const size_t max_bucket_bits,
bool handle_edge_cases);
template curve::BN254::Element pippenger_internal<curve::BN254>(std::span<const curve::BN254::AffineElement> points,
std::span<const curve::BN254::ScalarField> scalars,
PolynomialSpan<const curve::BN254::ScalarField> scalars,
const size_t num_initial_points,
pippenger_runtime_state<curve::BN254>& state,
bool handle_edge_cases);
Expand All @@ -1032,12 +1032,12 @@ template curve::BN254::AffineElement* reduce_buckets<curve::BN254>(affine_produc
bool first_round = true,
bool handle_edge_cases = false);

template curve::BN254::Element pippenger<curve::BN254>(std::span<const curve::BN254::ScalarField> scalars,
template curve::BN254::Element pippenger<curve::BN254>(PolynomialSpan<const curve::BN254::ScalarField> scalars,
std::span<const curve::BN254::AffineElement> points,
pippenger_runtime_state<curve::BN254>& state,
bool handle_edge_cases = true);

template curve::BN254::Element pippenger_unsafe<curve::BN254>(std::span<const curve::BN254::ScalarField> scalars,
template curve::BN254::Element pippenger_unsafe<curve::BN254>(PolynomialSpan<const curve::BN254::ScalarField> scalars,
std::span<const curve::BN254::AffineElement> points,
pippenger_runtime_state<curve::BN254>& state);

Expand Down
7 changes: 4 additions & 3 deletions barretenberg/cpp/src/barretenberg/ecc/scalar_multiplication/scalar_multiplication.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "./runtime_states.hpp"
#include "barretenberg/ecc/curves/bn254/bn254.hpp"
#include "barretenberg/ecc/curves/grumpkin/grumpkin.hpp"
#include "barretenberg/polynomials/polynomial.hpp"
#include <cstddef>
#include <cstdint>

Expand Down Expand Up @@ -135,7 +136,7 @@ void evaluate_addition_chains(affine_product_runtime_state<Curve>& state,
bool handle_edge_cases);
template <typename Curve>
typename Curve::Element pippenger_internal(typename Curve::AffineElement* points,
std::span<const typename Curve::ScalarField> scalars,
PolynomialSpan<const typename Curve::ScalarField> scalars,
size_t num_initial_points,
pippenger_runtime_state<Curve>& state,
bool handle_edge_cases);
Expand All @@ -151,12 +152,12 @@ typename Curve::AffineElement* reduce_buckets(affine_product_runtime_state<Curve
bool first_round = true,
bool handle_edge_cases = false);
template <typename Curve>
typename Curve::Element pippenger(std::span<const typename Curve::ScalarField> scalars,
typename Curve::Element pippenger(PolynomialSpan<const typename Curve::ScalarField> scalars,
std::span<const typename Curve::AffineElement> points,
pippenger_runtime_state<Curve>& state,
bool handle_edge_cases = true);
template <typename Curve>
typename Curve::Element pippenger_unsafe(std::span<const typename Curve::ScalarField> scalars,
typename Curve::Element pippenger_unsafe(PolynomialSpan<const typename Curve::ScalarField> scalars,
std::span<const typename Curve::AffineElement> points,
pippenger_runtime_state<Curve>& state);

Expand Down
Loading