feat: Replace Zeromorph with Shplemini in ECCVM #9102
+98
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maramihali
commented
Oct 9, 2024
| @@ -11,6 +11,7 @@ | |||
| using namespace bb; | |||
|
|
|||
| #pragma GCC diagnostic ignored "-Wunused-local-typedefs" | |||
| #pragma GCC diagnostic ignored "-Wunused-const-variable" | |||
There was a problem hiding this comment.
my buid was breaking without these warnings
maramihali
commented
Oct 9, 2024
iakovenkos
reviewed
Oct 9, 2024
|
|
||
| // Construct and verify the combined opening claim | ||
| auto batched_opening_claim = | ||
| const OpeningClaim batch_opening_claim = |
There was a problem hiding this comment.
I think the naming is a bit confusing, it would be great to clean them up. Maybe like sumcheck_batch_opening claims instead of batch_opening_claims and create an exlpiicit opening claim translation_batch_opening_claim, so that we see what the final batch opening claim is. + constify opening_claims
iakovenkos
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches ECCVM to Shplemini which shaves off ~300k in the tube circuit. Now, on the verifier side, we first execute Shplemini, then reduce the BatchOpeningClaim to a single OpeningClaim by performing the batch_mul delayed by Shplemini. Then, we construct the translation OpeningClaim, and the two are being reduced to a single OpeningClaim by executing a second iteration of Shplonk. Finally, we verify the OpeningClaim via PCS. This could be further optimised as we currently perform 4 batch_muls.