Updated node simple sample (doc and code) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now using npm package to run the sample Added loops to ensure the sample keeps on sending data and receiving notifications
| function printResultFor(op) { | ||
| return function printResult(err, res) { | ||
| if (err) console.log(op + ' error: ' + err.toString()); | ||
| if (res) console.log(op + ' status: ' + res.statusCode + ' ' + res.statusMessage); | ||
| if (res && (res.statusCode != 204)) console.log(op + ' status: ' + res.statusCode + ' ' + res.statusMessage); |
There was a problem hiding this comment.
It looks like you only want to print errors. But the 'if (err) ...' line already does that.
There was a problem hiding this comment.
Actually no, I want to print when I receive a result that is not 204 (which is empty) and not an error
|
I will close this one and send a new one from a fork to do a proper code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using npm package to run the sample
Added loops to ensure the sample keeps on sending data and receiving
notifications