chore(dependencies): Update superagent version #114

Tetsu9901 · 2023-07-28T12:22:37Z

We want to update the superagent version

Tetsu9901 · 2023-07-28T13:19:08Z

src/superagent-mock.js

-    } else {
-      // superagent < 3.6
-
-      if (isNodeServer) { // node server
-        const originalPath = this.path;
-        this.path = this.url;
-        this._appendQueryString(this); // use superagent implementation of adding the query
-        path = this.path; // save the url together with the query
-        this.path = originalPath; // reverse the addition of query to path by _appendQueryString
-      } else { // client
-        const originalUrl = this.url;
-        this._appendQueryString(this); // use superagent implementation of adding the query
-        path = this.url; // save the url together with the query
-        this.url = originalUrl; // reverse the addition of query to url by _appendQueryString
-      }


I change only this in this file

All other modification is prettier

fdubost · 2023-07-31T09:25:55Z

.eslintrc

@@ -7,7 +7,6 @@
    "no-underscore-dangle": 0,
    "no-use-before-define": [2, "nofunc"],
    "max-len": [2, 150, 2],
-    "quotes": [2, "single"],


Why this change? 👀 It generates a lot of noise in this PR 😕

My prettier modifie all files with " " instead of ' ' and
I can't do this :

"quotes": [2, "single", "double"]

So I removed it instead of revert all prettier modifications

I just saw your comment above but it is not a good reason to change lint rules in this project 😄 You should find why your prettier is misconfigured. Maybe a .prettierrc is missing here.

Yes it was planned but you are too fast for review 😅

fdubost · 2023-07-31T09:27:35Z

.github/workflows/node.js.yml

@@ -10,8 +10,8 @@ jobs:
    runs-on: ubuntu-latest
    strategy:
      matrix:
-        node-version: [10.x, 12.x, 14.x, 15.x]


We should maybe keep the compatibility with node 16 because it's a LTS 🦒

fdubost · 2023-07-31T09:28:11Z

package.json

@@ -16,10 +16,10 @@
    "url": "https://github.com/M6Web/superagent-mock"
  },
  "engines": {
-    "node": ">=10"
+    "node": "^18.0.0"


As said above, maybe 16 is better

Tetsu9901 · 2023-07-31T10:03:42Z

.prettierrc

+{
+    "singleQuote": true,
+    "printWidth": 120,
+    "trailingComma": "all",
+    "bracketSpacing": false
+}


This rules come from app-bedrock-web

It is a best practice to separate the refacto of prettier and the new code you want to add, here we can't see if a modification comes from the prettier refacto or not

SimonChaumet · 2023-07-31T12:22:06Z

package.json

  },
  "peerDependencies": {
-    "superagent": ">=3.6.0"
+    "superagent": ">=8.0.9"


Why is superagent a peer dependency instead of direct dependency ?

superagent-mock is not in responsibility for installing superagent in the project where it is used

SimonChaumet · 2023-07-31T12:33:34Z

.prettierrc

+{
+    "singleQuote": true,
+    "printWidth": 120,
+    "trailingComma": "all",
+    "bracketSpacing": false
+}


It is a best practice to separate the refacto of prettier and the new code you want to add, here we can't see if a modification comes from the prettier refacto or not

SimonChaumet · 2023-07-31T12:34:45Z

yarn.lock

Are we not supposed to move all projects to pnpm ?

SimonChaumet · 2023-07-31T12:38:39Z

tests/support/expectations.js

@@ -10,7 +10,6 @@ module.exports = function (request, config, isServer) {
    currentLog = log;
  };
  var superagentPackage = require('superagent/package.json');
-  var superagentUserAgentHeader = isServer ? {'User-Agent': 'node-superagent/' + superagentPackage.version} : {};


Why does this have been removed ?

The user agent is no longer set by the superagent library, so there's no point in testing its presence on the superagent-mock side

Tetsu9901 added the wip label Jul 28, 2023

Tetsu9901 self-assigned this Jul 28, 2023

Tetsu9901 commented Jul 28, 2023

View reviewed changes

Tetsu9901 force-pushed the update-superagent branch from 65a5015 to 79946af Compare July 28, 2023 13:47

Tetsu9901 removed the wip label Jul 28, 2023

Tetsu9901 marked this pull request as ready for review July 28, 2023 13:54

Tetsu9901 force-pushed the update-superagent branch from 79946af to b4bae73 Compare July 28, 2023 13:55

Tetsu9901 added the dependencies Pull requests that update a dependency file label Jul 28, 2023

Tetsu9901 force-pushed the update-superagent branch 2 times, most recently from 615432a to d0ee3c8 Compare July 31, 2023 09:20

Tetsu9901 requested a review from fdubost July 31, 2023 09:23

fdubost reviewed Jul 31, 2023

View reviewed changes

Tetsu9901 added the wip label Jul 31, 2023

Tetsu9901 force-pushed the update-superagent branch 4 times, most recently from 5b2362d to 008667d Compare July 31, 2023 09:55

Tetsu9901 commented Jul 31, 2023

View reviewed changes

fdubost approved these changes Jul 31, 2023

View reviewed changes

Art-G approved these changes Jul 31, 2023

View reviewed changes

SimonChaumet approved these changes Jul 31, 2023

View reviewed changes

Tetsu9901 added 4 commits July 31, 2023 17:12

test update superagent

286045f

remove superagentUserAgentHeader

cc5d774

update node

59280e4

update yarn-lock

4ad91f6

Tetsu9901 force-pushed the update-superagent branch from e9e3dca to e9d22a6 Compare July 31, 2023 15:19

fix prettier

f4fe7db

Tetsu9901 force-pushed the update-superagent branch from e9d22a6 to f4fe7db Compare July 31, 2023 15:21

Tetsu9901 requested review from fdubost and SimonChaumet July 31, 2023 15:22

fdubost approved these changes Jul 31, 2023

View reviewed changes

Tetsu9901 changed the title ~~Update superagent version~~ chore(superagent): Update superagent version Aug 1, 2023

Tetsu9901 added Community review and removed wip labels Aug 1, 2023

Tetsu9901 changed the title ~~chore(superagent): Update superagent version~~ chore(dependencies): Update superagent version Aug 1, 2023

Tetsu9901 merged commit 19d6415 into master Aug 1, 2023
2 checks passed

Tetsu9901 deleted the update-superagent branch August 1, 2023 08:28

Tetsu9901 restored the update-superagent branch August 1, 2023 14:18

Tetsu9901 deleted the update-superagent branch August 1, 2023 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(dependencies): Update superagent version #114

chore(dependencies): Update superagent version #114

Tetsu9901 commented Jul 28, 2023

Tetsu9901 Jul 28, 2023 •

edited

Loading

fdubost Jul 31, 2023

Tetsu9901 Jul 31, 2023 •

edited

Loading

fdubost Jul 31, 2023

Tetsu9901 Jul 31, 2023

fdubost Jul 31, 2023

fdubost Jul 31, 2023

Tetsu9901 Jul 31, 2023 •

edited

Loading

SimonChaumet Jul 31, 2023

SimonChaumet Jul 31, 2023

fdubost Jul 31, 2023

SimonChaumet Jul 31, 2023

SimonChaumet Jul 31, 2023

SimonChaumet Jul 31, 2023

Tetsu9901 Jul 31, 2023

chore(dependencies): Update superagent version #114

chore(dependencies): Update superagent version #114

Conversation

Tetsu9901 commented Jul 28, 2023

Tetsu9901 Jul 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tetsu9901 Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tetsu9901 Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tetsu9901 Jul 28, 2023 •

edited

Loading

Tetsu9901 Jul 31, 2023 •

edited

Loading

Tetsu9901 Jul 31, 2023 •

edited

Loading